Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote template default title #25

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Quote template default title #25

merged 1 commit into from
Jan 23, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 22, 2024

Some people put stuff like Contracts: my changes in there, which will be interpreted as nested value.
Just fixed two of those here: paritytech/polkadot-sdk@e81ed4d

Some people put stuff like `Contracts: my changes` in there, which will be interpreted as nested value.
@chevdor
Copy link
Contributor

chevdor commented Jan 23, 2024

Yes, IMO the fact that people use this pattern just shows the need for tags/topics.
It is fair that people want to provide a topic/category.

There should however not be a need for title: "Rococo and Westend Asset-Hub: XCM Transfers with Pallet-Uniques".

The following would be better as the title remains solely the title instead of a mash up of title + extra info:

title: "XCM Transfers with Pallet-Uniques"
topics:
   - Rococo and Westend Asset-Hub

or

title: "XCM Transfers with Pallet-Uniques"
topics:
   - Rococo Asset-Hub
   - Westend Asset-Hub

Forcing quotes is a workaround that would be better avoided.

@chevdor chevdor mentioned this pull request Jan 23, 2024
@chevdor chevdor merged commit 8652dc4 into master Jan 23, 2024
4 checks passed
@chevdor chevdor deleted the oty-template-title branch January 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants