This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
scheduler migration minor fixes #7638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
A0-please_review
none others that I could spot |
bkchr
approved these changes
Aug 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing scheduler pre/post hooks contain unnecessarily strict checks which will begin failing after the migration is applied, breaking our runtime migration CI checks.
I could have used
VersionedRuntimeUpgradehere, but it seemed overkill and I didn't want to break the API and cause unnecessary merge conflicts in Rob's async backing PR.pre_upgradechangeRemoved check ensuring on-chain version is 0.
This check is unnecessary as it is already checked in
on_runtime_upgrade, which skips the migration and warns the developer if the migration can be removed.post_upgradechange:Changed check ensuring the post-upgrade version == 1 to checking it is >= 1.
This check is unnecessary because all pallet
post_upgradehooks already check that the on-chain version matches the pallet version post-upgrade.