This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Document non-uniqueness of SetTopic IDs #7579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
bkontur
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
and also maybe some explicit comment to the WithUniqueTopic for the case message does end with a SetTopic
/// Wrapper router which, if the message does not already end with a
SetTopicinstruction,
/// appends one to the message filled with a universally unique ID. ...
franciscoaguirre
approved these changes
Aug 3, 2023
vstam1
approved these changes
Aug 4, 2023
gilescope
approved these changes
Aug 4, 2023
|
bot merge |
s0me0ne-unkn0wn
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Document non-uniqueness of SetTopic IDs * More comments on WithUniqueTopic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents that the parameter to
SetTopicare not guaranteed to be unique, and hence the code author is responsible to maintain uniqueness if so desired.