Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move vstaging to production #7341

Merged

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Jun 7, 2023

which enables past-session slashing on Polkadot and Kusama.

@the-right-joyce

Blocked by: paritytech/cumulus#2708

cumulus companion: paritytech/cumulus#2726

WIP: test-runtime still needs to be fixed.
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2956930

@eskimor eskimor changed the title Move vstaging to production (and thus past session slashing). Move vstaging to production Jun 8, 2023
@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 8, 2023
@eskimor eskimor marked this pull request as ready for review June 8, 2023 07:22
@paritytech-ci paritytech-ci requested review from a team June 8, 2023 07:22
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a minor method existence check issue

fn unapplied_slashes() -> Vec<(SessionIndex, CandidateHash, vstaging::slashing::PendingSlashes)>;

/// Returns a merkle proof of a validator session key.
#[api_version(5)]
/// NOTE: This function is only available since parachain host version 5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not ideal loosing version information when bumping base but it is what it is :(

@eskimor eskimor requested a review from rphmeier June 9, 2023 09:01
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excited to see this land!

@eskimor
Copy link
Member Author

eskimor commented Jun 12, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 04f8014 into master Jun 12, 2023
@paritytech-processbot paritytech-processbot bot deleted the rk-enable-past-session-slashing-production branch June 12, 2023 11:15
paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request Jun 12, 2023
* Companion to enabling past session slashing on production.

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: eskimor <[email protected]>
Co-authored-by: parity-processbot <>
ggwpez pushed a commit to ggwpez/runtimes that referenced this pull request Jul 13, 2023
* Companion to enabling past session slashing on production.

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: eskimor <[email protected]>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants