Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] #7337

Merged
merged 61 commits into from
Jul 31, 2023
Merged

98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] #7337

merged 61 commits into from
Jul 31, 2023

Commits on Jun 6, 2023

  1. [WIP] PVF: Split out worker binaries

    @mrcnski
    mrcnski committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    d2e068d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Merge branch 'master' into mrcnski/pvf-split-out-worker-binaries

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4ff0a66 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. Address compilation problems and re-design a bit

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    5bed726 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Reorganize once more, fix tests

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d7a389c View commit details
    Browse the repository at this point in the history

  2. Reformat with new nightly to make cargo fmt test happy

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    818778c View commit details
    Browse the repository at this point in the history

  3. Address clippy warnings

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    f9a9280 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-split-o… 

    …ut-worker-binaries
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    165f116 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-split-o… 

    …ut-worker-binaries
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2f192ea View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-split-o… 

    …ut-worker-binaries
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    01b97f8 View commit details
    Browse the repository at this point in the history

  3. Add temporary trace to debug zombienet tests

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    b5733fa View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-split-o… 

    …ut-worker-binaries
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    235766e View commit details
    Browse the repository at this point in the history

  2. Fix zombienet node upgrade test

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    f5ba965 View commit details
    Browse the repository at this point in the history

  3. Fix malus and its CI

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    7079e2f View commit details
    Browse the repository at this point in the history

  4. Fix building worker binaries with malus

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    95e643f View commit details
    Browse the repository at this point in the history

  5. More fixes for malus

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a1c093e View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-split-o… 

    …ut-worker-binaries
    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    5382cc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. Remove unneeded cli subcommands

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    06de32d View commit details
    Browse the repository at this point in the history

  2. Support placing auxiliary binaries to /usr/libexec

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    d7b5a5a View commit details
    Browse the repository at this point in the history

  3. Fix spelling

    @s0me0ne-unkn0wn
    s0me0ne-unkn0wn committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    49475c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Spelling 

    Co-authored-by: Marcin S. <[email protected]>
    @s0me0ne-unkn0wn @mrcnski
    s0me0ne-unkn0wn and mrcnski authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4c72864 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Implement review comments (mostly nits)

    @mrcnski
    mrcnski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    07d876e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mrcnski/pvf-split-out-worker-binaries

    @mrcnski
    mrcnski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    0da74cd View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Fix worker node version flag

    @mrcnski
    mrcnski committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    126213e View commit details
    Browse the repository at this point in the history

  2. Rework getting the worker paths

    @mrcnski
    mrcnski committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    6640b29 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Address a couple of review comments

    @mrcnski
    mrcnski committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    633edbc View commit details
    Browse the repository at this point in the history

  2. Minor restructuring

    @mrcnski
    mrcnski committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    41b0a49 View commit details
    Browse the repository at this point in the history

  3. Fix CI error

    @mrcnski
    mrcnski committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    49d8696 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Add tests for worker binaries detection

    @mrcnski
    mrcnski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    dc5d6a0 View commit details
    Browse the repository at this point in the history

  2. Improve tests; try to fix CI

    @mrcnski
    mrcnski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    6ef14fe View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Move workers module into separate file

    @mrcnski
    mrcnski committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    d2bef1f View commit details
    Browse the repository at this point in the history

  2. Try to fix failing test and workers not printing latest version 

    - Tests were not finding the worker binaries
- Workers were not being rebuilt when the version changed
- Made some errors easier to read
    @mrcnski
    mrcnski committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    3e09438 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Make a bunch of fixes

    @mrcnski
    mrcnski committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    55365d8 View commit details
    Browse the repository at this point in the history

  2. Rebuild nodes on version change

    @mrcnski
    mrcnski committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    751dd04 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Fix more issues

    @mrcnski
    mrcnski committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    76c16f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Fix tests

    @mrcnski
    mrcnski committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    a1e21dc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-split-o… 

    …ut-worker-binaries
    parity-processbot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7366c99 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Pass node version from node into dependencies to avoid recompiles 

    - [X] get version in CLI
- [X] pass it in to service
- [X] pass version along to PVF
- [X] remove rerun from service
- [X] add rerun to CLI

- [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)
    @mrcnski
    mrcnski committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    11bbf59 View commit details
    Browse the repository at this point in the history

  2. Some more improvements for smoother tests 

    - [X] Fix tests
- [X] Make puppet workers pass None for version and remove rerun
- [X] Make test collators self-contained
    @mrcnski
    mrcnski committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6244e3f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/mrcnski/pvf-split-out-worker-bin… 

    …aries' into mrcnski/pvf-split-out-worker-binaries
    @mrcnski
    mrcnski committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6f44e63 View commit details
    Browse the repository at this point in the history

  4. Add back rerun to PVF workers

    @mrcnski
    mrcnski committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    019bd97 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Move worker binaries into files in cli crate 

    As a final optimization I've separated out each worker binary from its own crate
into the CLI crate. Before, the worker bin shared a crate with the worker lib,
so when the binaries got recompiled so did the libs and everything transitively
depending on the libs. This commit fixes this regression that was causing
recompiles after every commit.
    @mrcnski
    mrcnski committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    df1117a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Fix bug (was passing worker version for node version)

    @mrcnski
    mrcnski committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    cde8dc6 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Move workers out of cli into root src/bin/ dir 

    - [X] Pass in node version from top-level (polkadot)
- [X] Add build.rs with rerun-git-head to root dir
    @mrcnski
    mrcnski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    98323d2 View commit details
    Browse the repository at this point in the history

  2. Add some sanity checks for workers to dockerfiles

    @mrcnski
    mrcnski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ecf0af8 View commit details
    Browse the repository at this point in the history

  3. Update malus 

      + [X] Make it self-contained
  + [X] Undo multiple binary changes
    @mrcnski
    mrcnski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3f929bb View commit details
    Browse the repository at this point in the history

  4. Try to fix clippy errors

    @mrcnski
    mrcnski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    508669c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into mrcnski/pvf-split-out-worker-binaries

    @mrcnski
    mrcnski committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    e072517 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Address cargo run issue 

    - [X] Add default-run for polkadot
- [X] Add note about installation to error
    @mrcnski
    mrcnski committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    432dcf3 View commit details
    Browse the repository at this point in the history

  2. Update readme (installation instructions)

    @mrcnski
    mrcnski committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7407507 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mrcnski/pvf-split-out-worker-binaries

    @mrcnski
    mrcnski committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0651bf6 View commit details
    Browse the repository at this point in the history

  4. Allow disabling external workers for local/testing setups 

      + [X] cli flag to enable single-binary mode
  + [X] Add message to error
    @mrcnski
    mrcnski committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5d9c711 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Revert unnecessary Cargo.lock changes

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1ce0c3e View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary build scripts from collators

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    09f4840 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mrcnski/pvf-split-out-worker-binaries

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    700ee0d View commit details
    Browse the repository at this point in the history

  4. Add back missing malus commands (should fix failing ZN job)

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8851c20 View commit details
    Browse the repository at this point in the history

  5. Some minor fixes

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    fd0f018 View commit details
    Browse the repository at this point in the history

  6. Update Cargo.lock

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e5771a0 View commit details
    Browse the repository at this point in the history

  7. Fix some build errors

    @mrcnski
    mrcnski committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0a04dd4 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Undo self-contained binaries; cli flag to disable version check 

      + [X] Remove --dont-run-external-workers
  + [X] Add --disable-worker-version-check
  + [X] Remove PVF subcommands
  + [X] Redo malus changes
    @mrcnski
    mrcnski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9f05299 View commit details
    Browse the repository at this point in the history

  2. Try to fix failing job and add some docs for local tests

    @mrcnski
    mrcnski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0477550 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mrcnski/pvf-split-out-worker-binaries

    @mrcnski
    mrcnski committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    70cd333 View commit details
    Browse the repository at this point in the history