-
Notifications
You must be signed in to change notification settings - Fork 1.6k
migration: unlock/unreserve Gov v1 balances, remove Gov V1 pallets from polkadot runtime, and remove Gov V1 pallet key/values from storage #7314
Conversation
…ama-gov-v1-storage-migration
…ama-gov-v1-storage-migration
…ama-gov-v1-storage-migration
What is this in the Kusama try-runtime log? Looks like a few hundreds of those.
|
It occurs when a lock is removed on an account that has zero consumers set, it is benign and can safely be ignored. @gpestana suggested in this comment that it's likely to be related to paritytech/polkadot-sdk#234. I was unable to log the offending accounts to check their state exactly (see the comment), but I did confirm that all the accounts "Unexpected underflow in reducing consumer" occurs for have real locks in Balances, so it's necessary to |
Needs paritytech/substrate#14779. Then, should be no more blockers 🤞 |
…ama-gov-v1-storage-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty! Much better approach! :)
…ama-gov-v1-storage-migration
// Check which one has more yes votes. | ||
( | ||
OriginCaller::Council(pallet_collective::RawOrigin::Members(l_yes_votes, l_count)), | ||
OriginCaller::Council(pallet_collective::RawOrigin::Members(r_yes_votes, r_count)), | ||
) => Some((l_yes_votes * r_count).cmp(&(r_yes_votes * l_count))), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI pipeline was cancelled due to failure one of the required jobs. |
bot merge force |
Partial paritytech/polkadot-sdk#485
Checklist
RemovePallet
migration scaffolding, to be activated when pallets are removed from the runtimeMigration summary
assuming DOT: $5.8, KSM: $25.95
Questions / to figure out
ERROR main runtime::system: Logic error: Unexpected underflow in reducing consumer
error logs