av-store: Move prune on a separate thread #7263
Conversation
alexggh
changed the title
alexggh
force-pushed
the
feature/my_first_commit
branch
2 times, most recently
from
7ff883b
to
f34c93f
Compare
alexggh
added
the
T4-parachains_engineering
alexggh
force-pushed
the
feature/my_first_commit
branch
from
f34c93f
to
261829a
Compare
alexggh
added
the
C1-low
sandreim
added
A0-please_review
| ctx.spawn_blocking( | ||
| "av-store-prunning", | ||
| Box::pin(async move { | ||
| let _timer = metrics.time_pruning(); |
There was a problem hiding this comment.
nit: I'd also add a debug! log here to know when pruning starts and ends. It would be nice to have when debugging.
There was a problem hiding this comment.
yep will do.
Done
Let’s burn it in and observe the pruning log and column usage. I also agree that this cannot break anything. |
Yeah, makes sense, I'll let you know once I have the results. |
| (pruning_result_tx, pruning_result_rx): ( | ||
| &mut MpscSender<Result<(), Error>>, | ||
| &mut MpscReceiver<Result<(), Error>>, | ||
| ), |
There was a problem hiding this comment.
nit: It would be simpler for this not to be a tuple, and it would save two lines. 😛
There was a problem hiding this comment.
you mean just to have two separate params pruning_result_tx and pruning_result_rx ?
There was a problem hiding this comment.
Yep. Just a style nit, feel free to ignore if you want.
There was a problem hiding this comment.
I will keep it as it is than :) , since I think it makes sense to try to have closely related params in the same data structure.
alexggh
force-pushed
the
feature/my_first_commit
branch
from
b9b5257
to
756d060
Compare
There are situations where pruning of the data could take more than a few seconds and that might make the whole subsystem unreponsive. To avoid this just move the prune process on a separate thread. See: paritytech#7237, for more details. Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
force-pushed
the
feature/my_first_commit
branch
from
756d060
to
0dde5a9
Compare
Ran this in versi for more than 24h, pruning was starting and stopping as expected. Looking at the data for database usage on 
So, I'm going to go ahead and merge this PR. |
|
Nice! Thanks @alexggh |
|
bot merge |
There are situations where pruning of the data could take more than a few seconds and that might make the whole subsystem unreponsive. To avoid this just move the prune process on a separate thread.
See: #7237, for more details.