Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

companion for #13555 #6842

Merged
merged 5 commits into from
Mar 15, 2023
Merged

companion for #13555 #6842

merged 5 commits into from
Mar 15, 2023

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 mentioned this pull request Mar 8, 2023
Merged
@paritytech-ci paritytech-ci requested review from a team March 8, 2023 12:40
@niklasad1 niklasad1 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. C1-low PR touches the given topic and has a low impact on builders. B0-silent Changes should not be mentioned in any release notes labels Mar 14, 2023
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 4f6502f

@niklasad1
Copy link
Member Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2524444

@niklasad1
Copy link
Member Author

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 14101d7

@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023 

 error[E0046]: not all trait items implemented, missing: `set_commission`, `set_commission_max`, `set_commission_change_rate`, `claim_commission`
    --> /builds/parity/mirrors/polkadot/runtime/polkadot/src/weights/pallet_nomination_pools.rs:47:1
     |
  47 | impl<T: frame_system::Config> pallet_nomination_pools::WeightInfo for WeightInfo<T> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `set_commission`, `set_commission_max`, `set_commission_change_rate`, `claim_commission` in implementation
     |

should be fixed here #6264 so lets merge.

@ggwpez ggwpez merged commit 36ab336 into master Mar 15, 2023
@ggwpez ggwpez deleted the na-companion-13555 branch March 15, 2023 13:34
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
05dc083 
* master: (50 commits)
  Issue 4393: Correcting Unnecessary Use of Arc (#6882)
  Companion for #13287  (#6655)
  timestamp ci job logs (#6890)
  Release parachain host API v4 (#6885)
  polkadot companion: #13128 (Pools commission) (#6264)
  companion for #13555 (#6842)
  Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600)
  Bump bumpalo from 3.8.0 to 3.12.0 (#6599)
  Bump git2 from 0.16.0 to 0.16.1 (#6601)
  Council as SpendOrigin (#6877)
  PVF: Document that preparation cannot lead to disputes (#6873)
  Sync versions with current release (0.9.39) (#6875)
  Companion for paritytech/substrate#13592 (#6869)
  Update orchestra to the recent version (#6854)
  Delete unused Cargo.lock (#6870)
  Remove use of Store trait (#6835)
  Companion for Substrate #13564 (#6845)
  Adding Dispute Participation Metrics (#6838)
  Update `substrate` to 48e7cb1 (#6851)
  Move PVF timeouts to executor environment parameters (#6823)
  ...
ordian added a commit that referenced this pull request Mar 21, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
b3b094c 
…slashing-client

* ao-past-session-slashing-runtime: (23 commits)
  Issue 4393: Correcting Unnecessary Use of Arc (#6882)
  Companion for #13287  (#6655)
  timestamp ci job logs (#6890)
  Release parachain host API v4 (#6885)
  polkadot companion: #13128 (Pools commission) (#6264)
  companion for #13555 (#6842)
  Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600)
  Bump bumpalo from 3.8.0 to 3.12.0 (#6599)
  Bump git2 from 0.16.0 to 0.16.1 (#6601)
  Council as SpendOrigin (#6877)
  PVF: Document that preparation cannot lead to disputes (#6873)
  Sync versions with current release (0.9.39) (#6875)
  Companion for paritytech/substrate#13592 (#6869)
  Update orchestra to the recent version (#6854)
  Delete unused Cargo.lock (#6870)
  Remove use of Store trait (#6835)
  Companion for Substrate #13564 (#6845)
  Adding Dispute Participation Metrics (#6838)
  Update `substrate` to 48e7cb1 (#6851)
  Move PVF timeouts to executor environment parameters (#6823)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@niklasad1 @paritytech-cicd-pr @ggwpez @ordian @kianenigma @bkchr @lexnv