This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use BTreeSet as the internal type of ParachainsCache
#6795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
reviewed
Feb 27, 2023
ordian
added
B0-silent
ordian
approved these changes
Feb 27, 2023
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
antonva/parachainscache-btreeset
branch
rphmeier
reviewed
Feb 27, 2023
| @@ -2127,7 +2127,7 @@ impl<T: Config> Pallet<T> { | |||
| /// or removing parachains in bulk. | |||
| pub(crate) struct ParachainsCache<T: Config> { | |||
| // `None` here means the parachains list has not been accessed yet, nevermind modified. | |||
| parachains: Option<Vec<ParaId>>, | |||
| parachains: Option<BTreeSet<ParaId>>, | |||
There was a problem hiding this comment.
Does this 100% have the same SCALE encoding format as the Vec? If not, this will break things, badly.
ggwpez
reviewed
Feb 27, 2023
| } | ||
| } | ||
|
|
||
| impl<T: Config> Drop for ParachainsCache<T> { | ||
| fn drop(&mut self) { | ||
| if let Some(parachains) = self.parachains.take() { | ||
| Parachains::<T>::put(¶chains); | ||
| Parachains::<T>::put(parachains.into_iter().collect::<Vec<ParaId>>()); |
There was a problem hiding this comment.
@rphmeier its being encode as Vec here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the complexity of batch operations on the parachains in storage as
BTreeSetinsert/remove isO(log(n)).