-
Notifications
You must be signed in to change notification settings - Fork 1.6k
approval-voting improvement: include all tranche0 assignments in one certificate #6782
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
- tuned test params to test single and multiple assignments Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/dynamic-backing-groups-preparing-cores-for-agile-scheduling/3629/3 |
Signed-off-by: Andrei Sandu <[email protected]>
…/vrf_modulo_comapct_assignment Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to give it an approval to signal readiness for an audit.
Just to be clear, before merging this, I expect to see the following addressed:
- merge conflicts resolved after async backing is merged
-
Versioned::VStaging
is stabilized intoVersioned::V2
- Another Versi burn-in after these changes
- audit (when v2 is actived)
@@ -1753,12 +2033,23 @@ impl ApprovalDistribution { | |||
ApprovalDistributionMessage::NewBlocks(metas) => { | |||
state.handle_new_blocks(ctx, metrics, metas, rng).await; | |||
}, | |||
ApprovalDistributionMessage::DistributeAssignment(cert, candidate_index) => { | |||
ApprovalDistributionMessage::DistributeAssignment(cert, candidate_indices) => { | |||
// TODO: Fix warning: `Importing locally an already known assignment` for multiple candidate assignments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to addressed before merge? If not, don't forget to create an issue :)
Thanks !
Yup, this is the next step.
My plan is to merge in master and piggy back on the network upgrade for async backing. Currently master code has the same naming with same semantics. But yeah, if we remove the feature flag until I merge, then it will have to be
Yes, this is in progress implicitly as we burn it along in #7554 , but I will do a separate test before the merge.
I am assuming we want to do the audit before the merge, then we are more flexible to when we enable the new code. |
Signed-off-by: Andrei Sandu <[email protected]>
…/vrf_modulo_comapct_assignment Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
fixes paritytech/polkadot-sdk#729
This PR will upgrade the network protocol to version 2 ->
VStaging
which will later be renamed toV2
. This version introduces a new kind of assignment certificate that will be used for tranche0 assignments. Instead of issuing/importing one tranche0 assignment per candidate, there will be just one certificate per relay chain block per validator. However, we will not be sending out the new assignment certificates, yet. So everything should work exactly as before. Once the majority of the validators have been upgraded to the new protocol version we will enable the new certificates (starting at a specific relay chain block) with a new client update.There are still a few things that need to be done:
Vec<CandidateIndex>
: approval-voting: implement some TODOs and remove v2 assignmentcore_indices
andsamples
#6802approval-distribution
andapproval-voting
testsbitfield-distribution
andstatement-distribution
testsRemove the approval distribution aggression levels: TBD PRcore_indices
andsamples
#6802DistributeAssignment
for each candidate claimed by a v2 assignment (warning:Importing locally an already known assignment
)AcceptedDuplicate