Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Retire OldV1SessionInfo #6744

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Retire OldV1SessionInfo #6744

merged 1 commit into from
Feb 20, 2023

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn commented Feb 19, 2023 •
edited
Loading

Closes #6722

Cumulus companion: paritytech/cumulus#2213

Removes support for the outdated OldV1SessionInfo structure and respective runtime client calls.

@s0me0ne-unkn0wn s0me0ne-unkn0wn added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 19, 2023
@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this pull request Feb 19, 2023
Merged
@s0me0ne-unkn0wn s0me0ne-unkn0wn marked this pull request as ready for review February 19, 2023 13:32
@s0me0ne-unkn0wn s0me0ne-unkn0wn added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. A0-please_review Pull request needs code review. and removed C1-low PR touches the given topic and has a low impact on builders. labels Feb 19, 2023
@s0me0ne-unkn0wn
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/cumulus#2213

@s0me0ne-unkn0wn
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/cumulus#2213

@s0me0ne-unkn0wn
Copy link
Contributor Author

😖 😖 😖

@s0me0ne-unkn0wn
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7cc5b88 into master Feb 20, 2023
@paritytech-processbot paritytech-processbot bot deleted the s0me0ne/retire-v1-session-info branch February 20, 2023 10:30
paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request Feb 20, 2023
@s0me0ne-unkn0wn @pmikolajczyk41
@dmitry-markin @ggwpez
Companion for paritytech/polkadot#6744: Retire OldV1SessionInfo (#2213
9ed57cf 
)

* Adjust commands

* Use `NetworkWorker::next_action()` instead of `poll()`

* rustfmt

* minor: fix mutability

* Move imports

* Replace `NetworkWorker::next_action()` with `run()`

* Import fix

* Make `NetworkWorker::run` consume self

* Retire `OldV1SessionInfo`

* update lockfile for {"polkadot", "substrate"}

* update lockfile for {"substrate", "polkadot"}

* update lockfile for {"substrate", "polkadot"}

* Make stuff compile

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Piotr Mikołajczyk <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ordian added a commit to paritytech/cumulus that referenced this pull request Feb 27, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-companion
a1df3e8 
* master: (35 commits)
  add turboflakes system-chains bootnodes (#2223)
  Companion for #13349 (#2217)
  bump `zombienet` version to v1.3.35 (#2226)
  [ci] Return benchmark to bm machines (#2225)
  Collectives chain xcm filter (#2222)
  Add metaspan.io parachain boot nodes (#2218)
  Companion for #13390 (#2189)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219)
  Benchmarks script improvements (#2214)
  `BlockId` removal: refactor of runtime API (#2190)
  Rename .feature extension to .zndsl (#2215)
  Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213)
  WIP: Fix templates (#2204)
  Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201)
  Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161)
  Bump clap from 4.1.4 to 4.1.6 (#2193)
  Bump toml from 0.6.0 to 0.7.2 (#2170)
  companion for paritytech/polkadot#6161 (#2151)
  Bump serde_json from 1.0.92 to 1.0.93 (#2175)
  add warp_sync_params (#1909)
  ...
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
7785be8 
* master: (98 commits)
  Ensure max_weight is assigned properly in AllowTopPaidExecutionFrom (#6787)
  Explicitly Handling ProvisionableData Cases (#6757)
  Companion for Substrate#12520 (#6730)
  Revert back to bare metal runners for weights generation (#6762)
  Improve XCM fuzzer (#6190)
  Corrected weight trader comment (#6752)
  clean up executed migrations (#6763)
  Remove state migration from westend runtime. (#6737)
  polkadot companion #12608 (Pools claim permissions) (#6753)
  Add Turboflakes bootnodes to Polkadot, Kusama and Westend (#6628)
  Companion for substrate#13284 (#6653)
  Companion for Substrate #13410: Introduce EnsureOrigin to democracy.propose (#6750)
  `BlockId` removal: `BlockBuilderProvider::new_block_at` (#6734)
  Companion PR for PR#13119 (#6683)
  Companion for Substrate#13411: frame/beefy: prune entries in set id session mapping (#6743)
  `BlockId` removal: refactor of runtime API (#6721)
  Fix auction bench (#6747)
  Use PVF code paired with executor params wherever possible (#6742)
  Retire `OldV1SessionInfo` (#6744)
  Companion for substrate #13121 - BEEFY Equivocations support (#6593)
  ...
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 22, 2023
@AurevoirXavier
Companion of paritytech/polkadot#6744
a3fa551
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request May 23, 2023
@AurevoirXavier @jiguantong @boundless-forest
To polkadot-v0.9.40 (#1153)
d87a45b 
* Remove `account`

* Update and companions

* Companion of paritytech/cumulus#2164

* Companion of paritytech/substrate#13159

* Companion of paritytech/cumulus#1909

* Fmt

* Companion of paritytech/polkadot#6744

* Companion of paritytech/cumulus#2245

* Companion of paritytech/substrate#12828

* Companion of paritytech/cumulus#2287

* Companion of paritytech/substrate#13592

* Companion of paritytech/cumulus#2308

* Companion of paritytech/substrate#13410

* Companion of paritytech/substrate#13305

* Companion of polkadot-evm/frontier#1050

* TODO weight

* TODO weight

* Companion of polkadot-evm/frontier#1040

Signed-off-by: Xavier Lau <[email protected]>

* Remove unused dep

* Try fix dev node paritytech/substrate#12828

* Fix the frontier part (#1154)

* Fix dev node

* Fmt

* Bump moonbeam

* Bump moonbeam

* Remove unnecessary clone

* Fix tests

---------

Signed-off-by: Xavier Lau <[email protected]>
Co-authored-by: Guantong <[email protected]>
Co-authored-by: bear <[email protected]>
ggwpez added a commit to ggwpez/runtimes that referenced this pull request Jul 13, 2023
@s0me0ne-unkn0wn @pmikolajczyk41
@dmitry-markin @ggwpez
Companion for paritytech/polkadot#6744: Retire OldV1SessionInfo (#2…
75cbf2f 
…213)

* Adjust commands

* Use `NetworkWorker::next_action()` instead of `poll()`

* rustfmt

* minor: fix mutability

* Move imports

* Replace `NetworkWorker::next_action()` with `run()`

* Import fix

* Make `NetworkWorker::run` consume self

* Retire `OldV1SessionInfo`

* update lockfile for {"polkadot", "substrate"}

* update lockfile for {"substrate", "polkadot"}

* update lockfile for {"substrate", "polkadot"}

* Make stuff compile

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Piotr Mikołajczyk <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tdimitrov tdimitrov tdimitrov approved these changes

@bkchr bkchr bkchr approved these changes

@eskimor eskimor Awaiting requested review from eskimor

@ordian ordian Awaiting requested review from ordian

@rphmeier rphmeier Awaiting requested review from rphmeier

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
No open projects
Parachains-core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retire OldV1SessionInfo
3 participants
@s0me0ne-unkn0wn @tdimitrov @bkchr