Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

v3::Junction supports small (32-byte max) "vecs". #6716

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Feb 14, 2023

As long as the key in GeneralKey is at most 32 bytes, round-trips between v2 & v3 should be fine.

@gavofyork gavofyork added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T6-XCM This PR/Issue is related to XCM. labels Feb 14, 2023
@gavofyork gavofyork marked this pull request as ready for review February 14, 2023 12:12
Copy link
Contributor

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavofyork gavofyork merged commit c77d92a into master Feb 14, 2023
@gavofyork gavofyork deleted the gav-xcm-generalkey-migration branch February 14, 2023 13:31
bkchr pushed a commit that referenced this pull request Feb 14, 2023
* v3::Junction supports small (32-byte max) "vecs".

* Formatting

* Add test
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T6-XCM This PR/Issue is related to XCM.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants