Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor PVF preparation memory stats #6693

Merged
merged 7 commits into from
Feb 14, 2023

Commits on Feb 9, 2023

  1. Refactor PVF preparation memory stats

    The original purpose of this change was to gate metrics that are unsupported by
    some systems behind conditional compilation directives (#[cfg]); see
    #6675 (comment).
    
    Then I started doing some random cleanups and simplifications and got a bit
    carried away. 🙈 The code should be overall tidier than before.
    
    Changes:
    - Don't register unsupported metrics (e.g. `max_rss` on non-Linux systems)
    - Introduce `PrepareStats` struct as an abstraction over the `Ok` values of
      `PrepareResult`. It is cleaner, and can be easily modified in the future.
    - Other small changes
    mrcnski committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    995abe1 View commit details
    Browse the repository at this point in the history
  2. Minor fixes to comments

    mrcnski committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3916503 View commit details
    Browse the repository at this point in the history
  3. Fix compile errors

    mrcnski committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    1058f07 View commit details
    Browse the repository at this point in the history
  4. Try to fix some Linux errors

    mrcnski committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    d5ea44f View commit details
    Browse the repository at this point in the history
  5. Mep

    mrcnski committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    39bb225 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5e2484e View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Update docstring

    mrcnski committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2b8afd3 View commit details
    Browse the repository at this point in the history