Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update changelog templates to use new labels #6585

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Update changelog templates to use new labels #6585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e76c2
Update changelog template to use new T labels
coderobe Jan 19, 2023
f6bb84c
update readme
coderobe Jan 19, 2023
49c9e8a
changelog gen: remove T6
coderobe Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions scripts/ci/changelog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ Currently, the considered labels are:
- E4 => new host function
- E2 => database migration
- B0 => silent, not showing up
- B1-releasenotes (misc unless other labels)
- B5-client (client changes)
- B7-runtimenoteworthy (runtime changes)
- T6-XCM
- B1 => noteworthy
- T0 => node
- T1 => runtime

Note that labels with the same letter are mutually exclusive.
A PR should not have both `B0` and `B5`, or both `C1` and `C9`. In case of conflicts, the template will
Expand Down
5 changes: 0 additions & 5 deletions scripts/ci/changelog/templates/change.md.tera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,5 @@
{%- set repo = " " -%}
{%- endif -%}

{%- if c.meta.T and c.meta.T.value == 6 -%}
{%- set xcm = " [✉️ XCM]" -%}
{%- else -%}
{%- set xcm = "" -%}
{%- endif -%}
Comment on lines -36 to -40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have the XCM tag, which is T6-XCM
So if you want to continue using it in the release notes, it's provided

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch

{{- repo }} {{ audit }}[`#{{c.number}}`]({{c.html_url}}) {{- prio }} - {{ c.title | capitalize | truncate(length=120, end="…") }}{{xcm }}
{%- endmacro change -%}
2 changes: 1 addition & 1 deletion scripts/ci/changelog/templates/changes_client.md.tera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
{#- We skip silent ones -#}
{%- else -%}

{%- if pr.meta.B.value == 5 and not pr.title is containing("ompanion") %}
{%- if pr.meta.T and pr.meta.T.value == 0 and not pr.title is containing("ompanion") %}
- {{ m_c::change(c=pr) }}
{%- endif -%}
{% endif -%}
Expand Down
4 changes: 2 additions & 2 deletions scripts/ci/changelog/templates/changes_misc.md.tera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{%- if pr.meta.B.value == 0 -%}
{#- We skip silent ones -#}
{%- else -%}
{%- if pr.meta.B and pr.meta.B.value != 5 and pr.meta.B.value != 7 or pr.meta.C or not pr.meta.B %}
{%- if pr.meta.T and pr.meta.T.value == 0 %}
{%- set_global misc_count = misc_count + 1 -%}
{%- endif -%}
{% endif -%}
Expand All @@ -27,7 +27,7 @@ There are other misc. changes. You can expand the list below to view them all.
{%- if pr.meta.B.value == 0 %}
{#- We skip silent ones -#}
{%- else -%}
{%- if pr.meta.B and pr.meta.B.value != 5 and pr.meta.B.value != 7 or pr.meta.C or not pr.meta.B %}
{%- if pr.meta.T and pr.meta.T.value == 0 %}
- {{ m_c::change(c=pr) }}
{%- endif -%}
{% endif -%}
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/changelog/templates/changes_runtime.md.tera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{#- We skip silent ones -#}
{%- else -%}

{%- if pr.meta.B.value == 7 and not pr.title is containing("ompanion") %}
{%- if pr.meta.T and pr.meta.T.value == 1 and not pr.title is containing("ompanion") %}
- {{ m_c::change(c=pr) }}
{%- endif -%}
{%- endif -%}
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/changelog/templates/high_priority.md.tera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The changes motivating this priority level are:
{%- if pr.meta.C -%}
{%- if pr.meta.C.value == p %}
- {{ m_c::change(c=pr) }}
{%- if pr.meta.B and pr.meta.B.value == 7 %} (RUNTIME)
{%- if pr.meta.T and pr.meta.T.value == 1 %} (RUNTIME)
{% endif %}
{%- endif -%}
{%- endif -%}
Expand Down