This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disputes rewards #5862
disputes rewards #5862
Changes from all commits
500c094
855a077
1c67070
f81f1ae
3e70157
5665053
5b8d2a4
e71e64c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both work and risk are the same as for backing, if we consider an individual validator:
Therefore era points similar to what we have for backing seems very sensible to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these numbers made up or sensible in some way?
How many era points do people get on average? and compared to making blocks and being online and whatever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backing points were introduced in #2089 and there's some discussion on the PR, but not much about the actual amount.
For dispute rewards, @eskimor made an argument above that it should be the same as for backing.
The main difference between these two is that backing should normally happen on each block (at most 1 per validator) and disputes should never normally happen, although they currently do happen.
This only applies to parachain validators, which is currently a 200 validators randomly selected from the active set.
As for era points people get on Kusama, it's around 4.5k per era per validator according to https://polkachu.com/kusama/era_summaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe DQ: Shouldn't we be checking also they participated in parachain consensus ? The active set is much larger than the
max_validators
setting (200 on Kusama/Polkadot).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
account_keys
is restricted to paravalidators, so it's filtered infilter_map(|i| validators.get(i.0 as usize).cloned())
.The reason to also filter those in the active set is because staking pallet can only reward current era (or even session) active validators AFAIK.