This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update RequestResponseConfig interface to match substrate #5849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-markin
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
labels
Aug 1, 2022
dmitry-markin
added
the
C1-low
PR touches the given topic and has a low impact on builders.
label
Aug 1, 2022
dmitry-markin
added
the
A4-companion
A PR that needs a companion PR to merge in parallel for one of its downstream dependencies.
label
Aug 2, 2022
acatangiu
approved these changes
Aug 4, 2022
ordian
approved these changes
Aug 4, 2022
Waiting for commit status. |
dmitry-markin
added
A8-mergeoncegreen
and removed
A0-please_review
Pull request needs code review.
labels
Aug 5, 2022
Merge cancelled due to error. Error: Statuses failed for 7f88793 |
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Aug 5, 2022
* master: Update RequestResponseConfig interface to match substrate (#5849)
ordian
added a commit
that referenced
this pull request
Aug 5, 2022
* master: Update RequestResponseConfig interface to match substrate (#5849)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A4-companion
A PR that needs a companion PR to merge in parallel for one of its downstream dependencies.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to paritytech/substrate#11938. This PR leaves the protocol names in Polkadot as they are and is here just to merge the Substrate changes. Separate PR is needed to change Polkadot protocol names to also include the genesis hash and fork id.