This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use Saturating Math in XCM #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B0-silent
bkchr
approved these changes
Aug 1, 2022
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
I added some more saturating. Please have a look @shawntabrizi
Btw would it be possible to un-implement the + operator on the Weight type?
Or make it panic instead? Then we would see all these occurrences as compile errors.
|
@ggwpez open to the idea! |
|
bot merge |
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Aug 3, 2022
* master: Use Saturating Math in XCM (#5845) Remove already executed calls to nompools MigrateToV2 migration (#5836) companion for #11821: node/service: add BEEFY to block import (#5796) Remove Unused Trait Bound (#5838) Companion for substrate#11523 (#5702) Remove Useless Inherent Data Provider (#5750) update weights (#5767) bump transcation_version for rococo (#5760) (#5830)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.