Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

companion to substrate 11411 #5524

Merged
merged 6 commits into from
May 20, 2022
Merged

companion to substrate 11411 #5524

merged 6 commits into from
May 20, 2022

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented May 15, 2022 •
edited
Loading

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels May 15, 2022
@paritytech-ci paritytech-ci requested review from a team May 15, 2022 07:15
@kianenigma kianenigma mentioned this pull request May 15, 2022
Merged
1 task
ggwpez
ggwpez approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it with the try-runtime?

@paritytech-ci paritytech-ci requested a review from a team May 16, 2022 11:26
@kianenigma
Copy link
Contributor Author

kianenigma commented May 16, 2022 •
edited
Loading

Did you try it with the try-runtime?

Now I did:

2022-05-16 20:59:14.678  INFO main westend_runtime: try-runtime::on_runtime_upgrade westend.
2022-05-16 20:59:14.678  INFO main runtime::nomination-pools: [10871639] 🏊‍♂️ Running migration with current storage version StorageVersion(1) / onchain StorageVersion(0)
2022-05-16 20:59:14.678  INFO main runtime::nomination-pools: [10871639] 🏊‍♂️ Upgraded 34 pools, storage to version StorageVersion(1)

@kianenigma
Copy link
Contributor Author

/cmd queue -v RUST_LOG=debug -c try-runtime $ --chain=westend-dev --execution=Wasm on-runtime-upgrade live --uri wss://westend-try-runtime-node.parity-chains.parity.io

@command-bot
Copy link

command-bot bot commented May 16, 2022 •
edited
Loading

cargo run --release --quiet --features=try-runtime try-runtime --chain=westend-dev --execution=Wasm on-runtime-upgrade live --uri wss://westend-try-runtime-node.parity-chains.parity.io was queued.

Comment /cmd cancel 3-56bdc7da-59c4-45b9-98d5-43b61e4fe7b0 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 16, 2022

@kianenigma Command cargo run --release --quiet --features=try-runtime try-runtime --chain=westend-dev --execution=Wasm on-runtime-upgrade live --uri wss://westend-try-runtime-node.parity-chains.parity.io has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

@joao-paulo-parity joao-paulo-parity mentioned this pull request May 17, 2022
Merged
@joao-paulo-parity
Copy link
Contributor

/cmd queue -v RUST_LOG=debug -c try-runtime $ --chain=westend-dev --execution=Wasm on-runtime-upgrade live --uri wss://westend-try-runtime-node.parity-chains.parity.io:443

@command-bot
Copy link

command-bot bot commented May 17, 2022 •
edited
Loading

@joao-paulo-parity https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1571025 was started for your command cargo run --release --quiet --features=try-runtime try-runtime --chain=westend-dev --execution=Wasm on-runtime-upgrade live --uri wss://westend-try-runtime-node.parity-chains.parity.io:443. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 1-f662ead0-7396-42d3-9037-20d29664aa6b to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 17, 2022

@joao-paulo-parity Command cargo run --release --quiet --features=try-runtime try-runtime --chain=westend-dev --execution=Wasm on-runtime-upgrade live --uri wss://westend-try-runtime-node.parity-chains.parity.io:443 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1571025 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1571025/artifacts/download.

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented May 17, 2022 •
edited
Loading

@kianenigma Seems like RUST_LOG=debug from #5524 (comment) was too excessive

https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1571025#L19

Job's log exceeded limit of 33554432 bytes.
Job execution will continue but no more output will be collected.

@joao-paulo-parity joao-paulo-parity mentioned this pull request May 17, 2022
Closed
@kianenigma kianenigma added the C1-low PR touches the given topic and has a low impact on builders. label May 19, 2022
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@sergejparity sergejparity added C1-low PR touches the given topic and has a low impact on builders. and removed C1-low PR touches the given topic and has a low impact on builders. labels May 20, 2022
@paritytech-processbot paritytech-processbot bot merged commit 58c5b9f into master May 20, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-compa-11411 branch May 20, 2022 11:20
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Github API says #5524 is not mergeable

@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Closed
This was referenced Jul 18, 2022
Closed
Open
@ghbot-test ghbot-test bot mentioned this pull request Jul 28, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergejparity sergejparity sergejparity approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kianenigma @joao-paulo-parity @shawntabrizi @bkchr @ggwpez @sergejparity