This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
service: don't use the grandpa observer #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
force-pushed
the
andre/disable-grandpa-observer
branch
from
5138399
to
900ed58
Compare
tasks spawned with `spawn_task`/`spawn_essential_task` are already guarded by `on_exit`.
gavofyork
reviewed
Oct 25, 2019
gavofyork
approved these changes
Oct 25, 2019
Co-Authored-By: Gavin Wood <[email protected]>
andresilva
added a commit
that referenced
this pull request
Oct 25, 2019
* service: don't use the grandpa observer * service: remove unnecessary boxing * service: fix indentation * service: remove unnecessary on_exit tasks spawned with `spawn_task`/`spawn_essential_task` are already guarded by `on_exit`. * Update service/src/lib.rs Co-Authored-By: Gavin Wood <[email protected]>
gavofyork
added a commit
that referenced
this pull request
Oct 25, 2019
* service: don't use the grandpa observer * service: remove unnecessary boxing * service: fix indentation * service: remove unnecessary on_exit tasks spawned with `spawn_task`/`spawn_essential_task` are already guarded by `on_exit`. * Update service/src/lib.rs Co-Authored-By: Gavin Wood <[email protected]>
gavofyork
added a commit
that referenced
this pull request
Oct 25, 2019
* add authority discovery module (#444) * grandpa: set justification period to 512 blocks (#445) * lock (#446) * Kusama CC2 spec (#449) * update readme for cc2 (#453) * docs: add security policy (#450) * docs: add security policy * Update SECURITY.md Co-Authored-By: joe petrowski <[email protected]> * Enable `substrate-session` `std` feature and remove unused traits (#456) * update (#457) * Update latest substrate master (#462) * update substrate to latest polkadot-master * fix test runtime * Fix compilation in wasm (#465) Also fix the weird file structure by making `wasm_executor.rs` -> `wasm_executor/mod.rs`. * Make `ParachainContext` take self as mutable (#458) This replicates changes to `Environment`/`Proposer` that are used internally at Cumulus. * wasm_executor: fix wasm signature checker (#471) Signed-off-by: yjhmelody <[email protected]> * Changes for substrate#3699 (#466) * change upstream and branch * Fix build * remove doc renamings * Fix tests * . * Revert changing fork and branch * Update Cargo.toml * Update parachains.rs * update branch name in Cargo.lock (#473) * Introduce Parathreads (runtime) (#341) * Rest of parathread draft implementation, parachain permissioning. * Update Substrate * Update Substrate again * Integrate weight/fee stuff. * Council * Build fixes * More fixes * Minor additions * fix some small errors * Revert "fix some small errors" This reverts commit 4fb52c8. * Merge fix. * do_swap -> on_swap * Update depdendency to polkadot-master * Fix more merge problems * Some patching of errors * Fix storage closure * Actually fix storage. It builds! * Tests run... but not successfully. * Add `run_to_block` to get parachains active to start * More `run_to_block` * Fix build * Queue up changes to threads * Move registration test * Fix regsiter/deregister test * Retry queue. * Minor refactor * Refactor to avoid heavy storage items * Make tests pass * remove para on deregister, add events * Remove println * Fix register/deregister parathread test * fix merge * Parathread can be activated test * Test auction * Add `Debtors` storage item I considered putting the debtor information in `ParaInfo`, but it did not make sense to me since this information only applies to parathreads, not `paras` in general. * remove comment code * Some new tests * Fixes for removing threads when scheduled. Tests. * Test progression of threads. * Test that reschedule queuing works properly. * Make test slightly more interesting * whitespace * Swap works properly. * Update locks * Build * Rename can_swap * Add test for funds to be correctly returned after a swap Swap does not seem to have logic which correctly swaps the debtor account to the new parathread. * Make tests consistant * Add check that `PendingSwap` is cleaned up * Update runtime/src/parachains.rs Co-Authored-By: Robert Habermeier <[email protected]> * Update runtime/src/registrar.rs Co-Authored-By: Robert Habermeier <[email protected]> * Some fixes/suggestions from review * Docs * Apply suggestions from code review Co-Authored-By: Robert Habermeier <[email protected]> Co-Authored-By: Shawn Tabrizi <[email protected]> * Update network/src/gossip.rs Co-Authored-By: Robert Habermeier <[email protected]> * Rename OnSwap * Add missing `]` * Rejig ordering semantics, making everything a bit slower but correct. * Some Fixes to Parathread Compile (#470) * Some Fixes * Fix queue_upward_messages * Change back to const * Build fixes * Fix tests * Update to latest Substrate master (#472) * Update to latest Substrate master * Fix * Fix compilation * fix var name for post_upward_message (#474) Signed-off-by: yjhmelody <[email protected]> * change versioning and tagging of releases (#476) * change versioning and tagging of releases * Make `ParaId` constructible from a const context (#483) * Pass `client` and `task_executor` to `BuildParachainContext` (#484) * Pass `client` and `task_executor` to `BuildParachainContext` * Update `Cargo.lock` * integrate minor weight/fee changes (#482) * Update cargo files * Make it build again. * Fix build * revert cargo file * New lockfile * Bump. * Update to latest Substrate master (#486) * Fixes required for Cumulus (#485) * Collator node need to register all gossip validators as well * Make sure that parachain authorities are only written once at genesis * Fix test * fix dockerfile build - upgrade image base from ubuntu 16 to 18 (#423) * Only register one gossip validator for full nodes (#487) * ci: fix publishing of ci builds (#488) * Support `account_nextIndex` RPC. (#460) * Use node-rpc extensions to support account_nextIndex. * Remove todo. * Update lock. * Use new srml_system_rpc crate. * Update to substrate=master * Update lockfile. * Update to polkadot-master. * Apply suggestions from code review Co-Authored-By: Bastian Köcher <[email protected]> * Update to latest substrate master (#491) * update to latest substrate master * Fix compilation * Switch elections to Phragmen, enable them in PoA (#492) * Switch elections to Phragmen, enable them in PoA * Remove superfluous code. * Build fixes * Update to substrate master * Build fixes * Add warning * Disable authority discovery for now * Remove commented code * Fix warning * service: cleanup task spawning (#495) * Update to latest substrate polkadot-master (#496) * update to latest substrate polkadot-master * Bump to 0.6.3 * service: don't use the grandpa observer (#494) (#498) * service: don't use the grandpa observer * service: remove unnecessary boxing * service: fix indentation * service: remove unnecessary on_exit tasks spawned with `spawn_task`/`spawn_essential_task` are already guarded by `on_exit`. * Update service/src/lib.rs Co-Authored-By: Gavin Wood <[email protected]>
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
…lock (paritytech#494) * Adds support for checking the timestamp inherent while validating a block This adds support for checking the timestamp inherent while validating a block. This will use the relay chain slot number * relay chain slot duration to calculate a timestamp. This timestamp is used to check the timestamp in the timestamp inherent. * Update polkadot-parachains/rococo-runtime/src/lib.rs Co-authored-by: Shawn Tabrizi <[email protected]> * Update polkadot-parachains/statemine-runtime/src/lib.rs Co-authored-by: Shawn Tabrizi <[email protected]> * Update primitives/timestamp/src/lib.rs Co-authored-by: André Silva <[email protected]> * Fix warnings Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: André Silva <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only setting this to v0.6 to play it safe on Kusama. We can re-enable the observer code later on after addressing all potential vote/block data availability concerns.