This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Feb 5, 2022
kianenigma
added
B7-runtimenoteworthy
and removed
B0-silent
Changes should not be mentioned in any release notes
labels
Feb 6, 2022
I mean, this seems fine, but could we just put this under governance instead? Or does it need to be so specific |
High think a governance proxy is more important than the society. I am in favour of keeping it separate, adding a new variant is non-breaking. |
shawntabrizi
approved these changes
Feb 7, 2022
gavofyork
approved these changes
Feb 12, 2022
bot merge |
Error: Checks failed for 1d0cbff |
bot merge |
Error: Checks failed for 1d0cbff |
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Checks failed for c1a3942 |
ordian
added a commit
that referenced
this pull request
Feb 22, 2022
* master: (27 commits) Bump `tokio` to 1.17.0 (#4965) bump transaction_version (#4956) Bump tracing-subscriber from 0.3.8 to 0.3.9 (#4954) staking miner: reuse ws conn for remote-ext (#4849) Revert "collator-protocol: short-term fixes for connectivity (#4640)" (#4914) Bump tracing from 0.1.30 to 0.1.31 (#4941) Better spam slots handling (#4845) Bump proc-macro-crate from 1.1.0 to 1.1.2 (#4936) corrected paras code validation event comments (#4932) Companion for refactor election score #10834 (#4927) Companion CI: Make sure to pass the update crates properly (#4928) update digest to v0.10.2 (#4907) Companion for #10832 (#4918) Companion for `Remove u32_trait` (#4920) Bump serde_json from 1.0.78 to 1.0.79 (#4916) Bump rand from 0.8.4 to 0.8.5 (#4917) Remove stale migrations post 9.16 release (#4848) Add proxy type for Kappa Sigma Mu (#4851) Baseline weights for `force_apply_min_commission` (#4896) Allow two Parachains to swap (#4772) ...
This was referenced Mar 4, 2022
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful for allowing other to vote for you in the society, perhaps if you know you are going to be going offline for an extended period of time.