Fix locked deposits of Nicks pallet #4656
Conversation
kianenigma
added
A0-please_review
|
I have found a subset of @kianenigma's accounts, the ones that have a 10 KSM reserve and some that have 0.01 KSM (I wasn't looking for 0.01 KSM reserves, as I wasn't aware the reserved amount had changed). My results for the accounts with 10 KSM reserve agree with Kian's results, as do the accounts with 0.01 KSM that I found. My approach can be found here: The only account that potentially has a reserve from |
| 116, 157, 220, 147, 166, 93, 254, 195, 175, 39, 204, 116, 120, 33, 44, 183, | ||
| 212, 176, 192, 53, 127, 239, 53, 160, 22, 57, 102, 171, 83, 51, 183, 87, | ||
| ], |
There was a problem hiding this comment.
would like to have the account id written as a comment above these different hexs for easier audit
There was a problem hiding this comment.
that's a good idea actually. I will add them, please manually check a few of them? they are all auto generated, so if one is correct, they all should be fine.
| 132, 250, 52, 33, 111, 141, 173, 223, 29, 75, 206, 46, 56, 72, 71, 124, 222, | ||
| 140, 211, 139, 226, 179, 165, 161, 38, 254, 36, 111, 96, 86, 124, 60, | ||
| ], | ||
| 10000000000000, |
There was a problem hiding this comment.
note that some accounts reserved 10KSM and some 10mKSM because of how the logic of the pallet changed, so variability here is expected.
|
bot merge |
* refund the lost deposit of historical nick module * Fix doc * add comments etc. * guard it better * more log * fix build
* refund the lost deposit of historical nick module * Fix doc * add comments etc. * guard it better * more log * fix build
The nicks pallet was removed at block 569325 from the runtime, without any consideration of the
fact that numerous accounts had reserved funds in this pallet. This migration is the outcome of
an investigation that tries to refund all of the accounts that had a nick set for them prior to
removal, if they still have the amount in their reserved balance. Otherwise, we ignore the
refund.
closes #3243
For the sake of posterity, the code that's used to generate this fix is here: https://gist.github.com/kianenigma/a34bcc2efcf753d986c199da62adffbd
Release Note Addition
Please make sure this is added to the release note of 9150 runtime for transparency: