This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
configuration: validation_upgrade_delay consistency #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Dec 22, 2021
pepyakin
added
B0-silent
pepyakin
force-pushed
the
pep-configuration-go-ahead-consistency
branch
from
5375a1d to
6b99e28
Compare
pepyakin
added
A3-in_progress
pepyakin
force-pushed
the
pep-pvf-consistency-checks
branch
from
011861e to
46cfb34
Compare
pepyakin
force-pushed
the
pep-configuration-go-ahead-consistency
branch
from
6b99e28 to
609c38a
Compare
pepyakin
added
A0-please_review
ordian
approved these changes
Dec 27, 2021
pepyakin
force-pushed
the
pep-pvf-consistency-checks
branch
from
46cfb34 to
8990811
Compare
pepyakin
force-pushed
the
pep-configuration-go-ahead-consistency
branch
from
609c38a to
3a94ef4
Compare
Closes #4248 Impose additional constraint on configuration consistency: `validation_upgrade_delay` should not be less than or equal to 1. See the original issue for more details.
pepyakin
force-pushed
the
pep-configuration-go-ahead-consistency
branch
from
3a94ef4 to
f058f30
Compare
|
Did you tested this with a lag in availability voting? The delay is calculated from the block the pov was build on and not the one it was enacted? |
|
For the record, @bkchr meant problem described in this PR #4246. That problem is solved by a previous PR in the stack: #4580. It puts a constraint that Footnotes
|
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
Closes #4248 Impose additional constraint on configuration consistency: `validation_upgrade_delay` should not be less than or equal to 1. See the original issue for more details.
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
Closes paritytech#4248 Impose additional constraint on configuration consistency: `validation_upgrade_delay` should not be less than or equal to 1. See the original issue for more details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4248
Impose additional constraint on configuration consistency:
validation_upgrade_delayshould not be less than or equal to 1.See the original issue for more details.
TODO: