Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[zombinet] initial implementation of zombienet backchannel #4377

Merged
merged 26 commits into from
Jan 7, 2022
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f9ef6b9
initial impl zombienet backchannel
pepoviola Nov 25, 2021
ce50d2f
clean code
pepoviola Nov 25, 2021
46c25b3
changes from feedback
pepoviola Nov 28, 2021
6a3b7c6
fmt and typo
pepoviola Nov 28, 2021
e6f73a1
remove default comment
pepoviola Nov 28, 2021
b3be116
refactor to use ws tx/rx
pepoviola Dec 7, 2021
b3eed29
fmt
pepoviola Dec 7, 2021
91b6975
Merge branch 'master' into javier-zombienet-backchannel
pepoviola Dec 7, 2021
5953051
derive Clone for ZombienetBackchannel
pepoviola Dec 7, 2021
e340d32
Revert "derive Clone for ZombienetBackchannel"
pepoviola Dec 7, 2021
0ccb705
change tracing prefix value
pepoviola Dec 9, 2021
39dae39
Merge branch 'master' into javier-zombienet-backchannel
pepoviola Dec 14, 2021
f3014e7
refactor backchannel
pepoviola Dec 14, 2021
1558d42
Update node/zombienet-backchannel/Cargo.toml
pepoviola Dec 14, 2021
bd729ae
add docs to broadcaster methods
pepoviola Dec 14, 2021
486794f
add more docs
pepoviola Dec 14, 2021
ed47fee
Merge branch 'master' into javier-zombienet-backchannel
pepoviola Dec 23, 2021
16a7b99
fmt
pepoviola Dec 23, 2021
c83269d
Merge branch 'master' into javier-zombienet-backchannel
pepoviola Jan 6, 2022
1e001cd
fix spellcheck
pepoviola Jan 6, 2022
d1e4223
update lock file
pepoviola Jan 6, 2022
1a38285
remove unused
pepoviola Jan 6, 2022
e4d9dbc
fmt
pepoviola Jan 6, 2022
c5a0791
Merge branch 'master' into javier-zombienet-backchannel
pepoviola Jan 7, 2022
9cda227
changes from feedback
pepoviola Jan 7, 2022
d14b7c8
fmt
pepoviola Jan 7, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ members = [
"node/test/polkadot-simnet/common",
"node/test/polkadot-simnet/node",
"node/test/polkadot-simnet/test",
"node/zombienet-backchannel",
"parachain/test-parachains",
"parachain/test-parachains/adder",
"parachain/test-parachains/adder/collator",
Expand Down
22 changes: 22 additions & 0 deletions node/zombienet-backchannel/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[package]
name = "zombienet-backchannel"
description = "Zombienet backchannel to notify test runner and coordinate with malus actors."
license = "GPL-3.0-only"
version = "0.9.13"
authors = ["Parity Technologies <[email protected]>"]
edition = "2018"
pepoviola marked this conversation as resolved.
Show resolved Hide resolved
readme = "README.md"
publish = false

[dependencies]
tokio = { version = "1.0.0", default-features = false, features = ["macros", "net", "rt-multi-thread", "sync"] }
url = "2.0.0"
tokio-tungstenite = "0.16"
futures-util = "0.3.18"
lazy_static = "1.4.0"
parity-scale-codec = { version = "2.3.1", features = ["derive"] }
reqwest = "0.11"
thiserror = "1.0.30"
tracing = "0.1.26"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1"
33 changes: 33 additions & 0 deletions node/zombienet-backchannel/src/errors.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// Copyright 2021 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.

// Polkadot is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.

// Polkadot is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.

// You should have received a copy of the GNU General Public License
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.

//! Polkadot Zombienet Backchannel error definitions.

#[derive(Debug, thiserror::Error)]
#[allow(missing_docs)]
pub enum BackchannelError {
#[error("Error connecting websocket server")]
CantConnectToWS,

#[error("Backchannel not initialized yet")]
Uninitialized,

#[error("Backchannel already initialized")]
AlreadyInitialized,

#[error("Error sending new value to backchannel")]
SendItemFail,
}
154 changes: 154 additions & 0 deletions node/zombienet-backchannel/src/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
// Copyright 2017-2021 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.

// Polkadot is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.

// Polkadot is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.

// You should have received a copy of the GNU General Public License
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.

//! Provides the possibility to coordination between malicious actors and
//! the zombienet test-runner, allowing to reference runtime's generated
//! values in the test specifications, through a bidirectional message passing
//! implemented as a `backchannel`.

use futures_util::{stream::SplitSink, SinkExt, StreamExt};
use lazy_static::lazy_static;
use parity_scale_codec as codec;
use serde::{Deserialize, Serialize};
use std::env;
use std::sync::Mutex;
use tokio::{net::TcpStream, sync::broadcast};
use tokio_tungstenite::{
connect_async, tungstenite::protocol::Message, MaybeTlsStream, WebSocketStream,
};

mod errors;
use errors::BackchannelError;

lazy_static! {
pub static ref ZOMBIENET_BACKCHANNEL: Mutex<Option<ZombienetBackchannel>> = Mutex::new(None);
}

#[derive(Debug)]
pub struct ZombienetBackchannel {
broadcast_tx: broadcast::Sender<BackchannelItem>,
ws_tx: broadcast::Sender<BackchannelItem>,
}

#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct BackchannelItem {
key: String,
value: String,
}

pub struct Broadcaster;

pub const ZOMBIENET: &str = "🧟ZOMBIENET🧟";

impl Broadcaster {
pub fn subscribe(&self) -> Result<broadcast::Receiver<BackchannelItem>, BackchannelError> {
pepoviola marked this conversation as resolved.
Show resolved Hide resolved
let mut zombienet_bkc = ZOMBIENET_BACKCHANNEL.lock().unwrap();
let sender = zombienet_bkc.as_mut().unwrap().broadcast_tx.clone();
pepoviola marked this conversation as resolved.
Show resolved Hide resolved
if zombienet_bkc.is_some() {
Ok(sender.subscribe())
} else {
Err(BackchannelError::Uninitialized)
}
}

pub async fn send(
&mut self,
key: &'static str,
val: impl codec::Encode,
) -> Result<(), BackchannelError> {
let mut zombienet_bkc = ZOMBIENET_BACKCHANNEL.lock().unwrap();
if zombienet_bkc.is_none() {
return Err(BackchannelError::Uninitialized);
}
let encoded = val.encode();
let backchannel_item = BackchannelItem {
key: key.to_string(),
value: String::from_utf8_lossy(&encoded).to_string(),
};

let sender = zombienet_bkc.as_mut().unwrap().ws_tx.clone();
pepoviola marked this conversation as resolved.
Show resolved Hide resolved
sender.send(backchannel_item).map_err(|e| {
tracing::error!(target = ZOMBIENET, "Error sending new item: {}", e);
BackchannelError::SendItemFail
})?;

Ok(())
}
}

impl ZombienetBackchannel {
pub async fn init() -> Result<(), BackchannelError> {
let mut zombienet_bkc = ZOMBIENET_BACKCHANNEL.lock().unwrap();
if zombienet_bkc.is_none() {
let backchannel_host =
env::var("BACKCHANNEL_HOST").unwrap_or_else(|_| "backchannel".to_string());
let backchannel_port =
env::var("BACKCHANNEL_PORT").unwrap_or_else(|_| "3000".to_string());
pepoviola marked this conversation as resolved.
Show resolved Hide resolved
let ws_url = format!("ws://{}:{}/ws", backchannel_host, backchannel_port);
tracing::debug!(target = ZOMBIENET, "Connecting to : {}", &ws_url);
let (ws_stream, _) =
connect_async(ws_url).await.map_err(|_| BackchannelError::CantConnectToWS)?;
let (mut write, mut read) = ws_stream.split();

let (tx, _rx) = broadcast::channel(256);
let (tx_relay, mut rx_relay) = broadcast::channel::<BackchannelItem>(256);

// receive from the ws and send to all subcribers
let tx1 = tx.clone();
tokio::spawn(async move {
while let Some(Ok(Message::Text(text))) = read.next().await {
match serde_json::from_str::<BackchannelItem>(&text) {
Ok(backchannel_item) => {
if tx1.send(backchannel_item).is_err() {
tracing::error!("Error sending through the channel");
return;
}
}
Err(_) => {
tracing::error!("Invalid payload received");
}
}
}
});

// receive from subscribers and relay to ws
tokio::spawn(async move {
while let Ok(item) = rx_relay.recv().await {
if write
.send(Message::Text(serde_json::to_string(&item).unwrap()))
.await
.is_err()
{
tracing::error!("Error sending through ws");
}
}
});

*zombienet_bkc = Some(ZombienetBackchannel { broadcast_tx: tx, ws_tx: tx_relay });
return Ok(());
}

Err(BackchannelError::AlreadyInitialized)
}

pepoviola marked this conversation as resolved.
Show resolved Hide resolved
pub fn broadcaster() -> Result<Broadcaster, BackchannelError> {
if ZOMBIENET_BACKCHANNEL.lock().unwrap().is_some() {
Ok(Broadcaster {})
} else {
Err(BackchannelError::Uninitialized)
}
}
}