-
Notifications
You must be signed in to change notification settings - Fork 1.6k
weights: pallet-staking & pallet-bags-list #3872
Conversation
/benchmark runtime kusama pallet_bags_list |
/benchmark runtime kusama pallet_staking |
Starting benchmark for branch: zeke-weigh-staking-and-bags (vs master) Toolchain: Comment will be updated. |
/benchmark runtime kusama pallet_staking |
Benchmark Runtime Kusama Pallet for branch "zeke-weigh-staking-and-bags" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Results
|
…zeke-weigh-staking-and-bags
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
/benchmark runtime kusama pallet_bags_list |
Benchmark Runtime Kusama Pallet for branch "zeke-weigh-staking-and-bags" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/ Results
|
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/
/benchmark runtime polkadot pallet_bags_list |
Benchmark Runtime Polkadot Pallet for branch "zeke-weigh-staking-and-bags" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
ERROR: Unable to commit file ./runtime/polkadot/src/weights/ |
/benchmark runtime polkadot pallet_staking |
Benchmark Runtime Polkadot Pallet for branch "zeke-weigh-staking-and-bags" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/ Results
|
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/
/benchmark runtime westend pallet_bags_list |
Benchmark Runtime Westend Pallet for branch "zeke-weigh-staking-and-bags" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ Results
|
…zeke-weigh-staking-and-bags
after the other westend one, just need to run "benchmark runtime westend pallet_staking" and then i think this is done |
…k --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
/benchmark runtime westend pallet_staking |
Benchmark Runtime Westend Pallet for branch "zeke-weigh-staking-and-bags" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/ Results
|
…k --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/
// Storage: System Account (r:1 w:1) | ||
// Storage: BagsList ListNodes (r:3 w:3) | ||
// Storage: Staking Bonded (r:1 w:0) | ||
// Storage: BagsList ListBags (r:2 w:2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to make a follow up issue to consider refund for these operations. All of this is the worst case now (which is totally intentional)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Storage: Staking SlashingSpans (r:21 w:0) | ||
// Storage: Staking Nominators (r:1001 w:0) | ||
// Storage: System BlockWeight (r:1 w:1) | ||
fn get_npos_voters(v: u32, n: u32, s: u32, ) -> Weight { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm how is this benchmark not reading the bags list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just because right now we don't iter over the bags, but instead the nominators map - https://github.com/paritytech/substrate/blob/master/frame/staking/src/pallet/impls.rs#L685 &
polkadot/runtime/common/src/elections.rs
Lines 106 to 108 in e0a53cf
fn iter() -> Box<dyn Iterator<Item = T::AccountId>> { | |
Box::new(pallet_staking::Nominators::<T>::iter().map(|(n, _)| n)) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR is that the fees/weight for staking in kusama is not more for some transactions, polkadot stays the same, as expected. LGTM, except my last comments.
bot merge |
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
bot merge force |
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
bot merge |
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
bot merge |
Trying merge. |
* master: weights: pallet-staking & pallet-bags-list (#3872) Re-enable metadata compare CI check (#3895) Bump `parity-util-mem` to 0.10.2 (#3897) Revert "remove connected disconnected state only (#3868)" (#3896) Companion for Generate storage info for pallet im_online #9654 (#3744) Gather memory usage statistics through `parity-util-mem` (#3893) ci: cache seed in fuzzer job (#3885) Add benchmarking for parachain runtime configuration pallet (#3862) Run fmt (#3887) remove connected disconnected state only (#3868) Dispute distribution improvements (#3853) Companion for Store voters in unsorted bags to get good stake iteration properties (#3413) Add info logging to dispute activation (#3870) update Rococo.json (#3871) Companion for #9764 (Force Unreserve) (#3840)
Update weights following #3413