Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change pipeline to use Vault #3722

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Change pipeline to use Vault #3722

merged 6 commits into from
Sep 8, 2021

Conversation

sergejparity
Copy link
Contributor

Change pipeline to use Vault as source for variables

@sergejparity sergejparity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 30, 2021
@sergejparity sergejparity marked this pull request as ready for review August 30, 2021 22:55
@sergejparity sergejparity added the A3-in_progress Pull request is in progress. No review needed at this stage. label Aug 31, 2021
@sergejparity sergejparity added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Aug 31, 2021
@sergejparity sergejparity self-assigned this Aug 31, 2021
.gitlab-ci.yml Outdated
@@ -384,6 +436,13 @@ publish-s3-release: &publish-s3
variables:
GIT_STRATEGY: none
PREFIX: "builds/polkadot/${ARCH}-${DOCKER_OS}"
secrets:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this secrets is separate from the one on top of the file?

Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergejparity sergejparity merged commit eb12f83 into master Sep 8, 2021
@sergejparity sergejparity deleted the sk-ci-vars-from-vault branch September 8, 2021 18:39
ordian added a commit that referenced this pull request Sep 9, 2021
* master:
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  Change pipeline to use Vault (#3722)
  Don't drop UMP queue items if weight exhausted (#3784)
  Fix flaky availability-recovery test (#3812)
  participate in disputes only if haven't voted already (#3796)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants