This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergejparity
added
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
labels
Aug 30, 2021
sergejparity
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Aug 31, 2021
sergejparity
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
labels
Aug 31, 2021
TriplEight
reviewed
Sep 8, 2021
.gitlab-ci.yml
Outdated
@@ -384,6 +436,13 @@ publish-s3-release: &publish-s3 | |||
variables: | |||
GIT_STRATEGY: none | |||
PREFIX: "builds/polkadot/${ARCH}-${DOCKER_OS}" | |||
secrets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this secrets
is separate from the one on top of the file?
TriplEight
approved these changes
Sep 8, 2021
TriplEight
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ordian
added a commit
that referenced
this pull request
Sep 9, 2021
* master: Bump tokio from 1.10.1 to 1.11.0 (#3821) Add words to the dictionnary (#3819) Add vault secrets to puplish-rustdoc job (#3816) Change pipeline to use Vault (#3722) Don't drop UMP queue items if weight exhausted (#3784) Fix flaky availability-recovery test (#3812) participate in disputes only if haven't voted already (#3796)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change pipeline to use Vault as source for variables