This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for Substrate#9165 #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A0-please_review
gui1117
reviewed
Jul 27, 2021
|
|
||
| impl OnRuntimeUpgrade for MigratePalletVersionToStorageVersion { | ||
| fn on_runtime_upgrade() -> frame_support::weights::Weight { | ||
| frame_support::migrations::migrate_from_pallet_version_to_storage_version::<AllPalletsWithSystem>( |
There was a problem hiding this comment.
this will write the new version to the storage before executing the pallet specific hooks,
If some hooks rely on the stored version, this upgrade can break them.
I'll double check now, but I guess we should double check before the next releases as well.
gui1117
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
looks good to me, about https://github.com/paritytech/polkadot/pull/3526/files#r677620613 the only runtime upgrade that looks into the stored version is pallet-contract but we don't use it here.
added 2 commits
July 27, 2021 21:21
|
Waiting for commit status. |
ghost
merged commit
This was referenced Sep 7, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#9165