This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove hack around Yamux window size #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
|
Thanks! I planed doing this, once pov distribution and availability recovery are request response. |
eskimor
added
the
D3-trivial 🧸
eskimor
approved these changes
Apr 9, 2021
ordian
approved these changes
Apr 9, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this now in order to not forget to do this, because it needs to go in before we enable
real-overseerin production.The comment mentions needing request-response protocols for collations.
While the collation still doesn't use request-responses, this comment was based on the idea that we would increase the yamux
window size of request-response substreams.
Instead we went with a different approach and decided to send back back ACKs half-way through as a way to improve the transfer rate.
Switching to request-response is therefore completely orthogonal to the yamux window size.
cc #2283