This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Request based collation fetching #2594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
added
A3-in_progress
- Missing: tests - Collator side - don't connect, if not connected
eskimor
force-pushed
the
rk-collation-2591
branch
from
50bcf94 to
999ace3
Compare
Also some cleanup.
eskimor
changed the title
github-actions
bot
added
A0-please_review
ordian
reviewed
Mar 14, 2021
Comment on lines
+30
to
+31
| [target.'cfg(not(target_os = "unknown"))'.dependencies] | ||
| zstd = "0.5.0" |
There was a problem hiding this comment.
we could make it an optional dependency and include it in std feature as we do for other such deps
There was a problem hiding this comment.
I sorry, I remember now there were troubles compiling zstd to wasm
#2288 (comment)
maybe this suggestion was wrong, but I think we can make it both optional and gated by unknown target
eskimor
force-pushed
the
rk-collation-2591
branch
from
7e24d42 to
6659aab
Compare
eskimor
force-pushed
the
rk-collation-2591
branch
3 times, most recently
from
292864c to
8a1aaed
Compare
eskimor
force-pushed
the
rk-collation-2591
branch
from
8a1aaed to
4202d3c
Compare
|
Re-opened here. (CI behaved weirdly, maybe I hit a rate limit or something) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2591
Big part of #2283