Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update substrate reference #249

Merged
merged 2 commits into from
May 8, 2019
Merged

update substrate reference #249

merged 2 commits into from
May 8, 2019

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented May 7, 2019

No description provided.

@rphmeier rphmeier added the A0-please_review Pull request needs code review. label May 7, 2019
@@ -73,6 +73,15 @@ use std::collections::{HashMap, HashSet};
#[cfg(test)]
mod tests;

mod cost {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there also be a positive reputation, when good things happen?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I added this which should be done ASAP: #251

@tomaka
Copy link
Contributor

tomaka commented May 7, 2019

Please note though that report_peer would previously disconnect the node, but this is no longer true.
You have to call ctx.disconnect_peer (a method that didn't exist before) to force a disconnect.

@gavofyork gavofyork merged commit 987da51 into master May 8, 2019
@gavofyork gavofyork deleted the rh-update-substrate branch May 8, 2019 10:10
tomusdrw added a commit that referenced this pull request Mar 26, 2021
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants