Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[CI] Move check_labels to github actions #2415

Merged
7 commits merged into from
Feb 10, 2021
Merged

[CI] Move check_labels to github actions #2415

7 commits merged into from
Feb 10, 2021

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Feb 10, 2021

As per @bkchr 's request, this allows us to run the job when editing labels, meaning the dev doesn't have to re-run the job in gitlab after applying labels.

@TriplEight Could you please remove continuous-integration/gitlab-check-labels as a required status check in the master branch protection rules please, and add this new Github actions in its place? Cheers

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 10, 2021
@s3krit s3krit added the B0-silent Changes should not be mentioned in any release notes label Feb 10, 2021
@s3krit s3krit added the C1-low PR touches the given topic and has a low impact on builders. label Feb 10, 2021
@TriplEight
Copy link
Contributor

Changed the required status in branch protection.

Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you remove the gitlab job then?

@s3krit
Copy link
Contributor Author

s3krit commented Feb 10, 2021

Because I'm dumb :P done

Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see :P

@bkchr bkchr added C1-low PR touches the given topic and has a low impact on builders. and removed C1-low PR touches the given topic and has a low impact on builders. labels Feb 10, 2021
@bkchr
Copy link
Member

bkchr commented Feb 10, 2021

bot merge

@ghost
Copy link

ghost commented Feb 10, 2021

Waiting for commit status.

@ghost ghost merged commit 00ca302 into master Feb 10, 2021
@ghost ghost deleted the mp-check-labels-action branch February 10, 2021 17:50
ordian added a commit that referenced this pull request Feb 11, 2021
* master:
  Implement Approval Voting Subsystem (#2112)
  Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420)
  [CI] Move check_labels to github actions (#2415)
  runtime: set equivocation report longevity (#2404)
  Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331)
  Corrected Physical (#2414)
  validator_discovery: cache by (Hash, ParaId) (#2402)
  Enable wasmtime caching for PVF (companion for #8057) (#2387)
  Use construct_runtime in tests, remove default PalletInfo impl (#2409)
  validator_discovery: pass PeerSet to the request (#2372)
  guide: more robust approval counting procedure (#2378)
  Publish rococo on every push to `rococo-v1` branch (#2388)
  Bump trie-db from 0.22.2 to 0.22.3 (#2344)
  Send view to new peers (#2392)
ordian added a commit that referenced this pull request Feb 11, 2021
* master:
  Implement Approval Voting Subsystem (#2112)
  Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420)
  [CI] Move check_labels to github actions (#2415)
  runtime: set equivocation report longevity (#2404)
  Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331)
  Corrected Physical (#2414)
  validator_discovery: cache by (Hash, ParaId) (#2402)
  Enable wasmtime caching for PVF (companion for #8057) (#2387)
  Use construct_runtime in tests, remove default PalletInfo impl (#2409)
  validator_discovery: pass PeerSet to the request (#2372)
  guide: more robust approval counting procedure (#2378)
  Publish rococo on every push to `rococo-v1` branch (#2388)
  Bump trie-db from 0.22.2 to 0.22.3 (#2344)
  Send view to new peers (#2392)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants