Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #7536 (Pallet Treasury Refactor) #2025

Merged
24 commits merged into from
Dec 16, 2020
Merged

Companion for #7536 (Pallet Treasury Refactor) #2025

24 commits merged into from
Dec 16, 2020

Conversation

shamb0
Copy link
Contributor

@shamb0 shamb0 commented Nov 27, 2020 •
edited by shawntabrizi
Loading

Polkadot Companion for paritytech/substrate#7536

@shamb0 shamb0 mentioned this pull request Nov 28, 2020
Merged
shawntabrizi
shawntabrizi approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs to complete that Substrate PR and then we should run weights one last time before merge

@shawntabrizi shawntabrizi marked this pull request as ready for review November 29, 2020 03:52
@shawntabrizi shawntabrizi changed the title Issue 7143 pallet treasury refactor Companion for #7143 (Pallet Treasury Refactor) Nov 29, 2020
@shawntabrizi shawntabrizi changed the title Companion for #7143 (Pallet Treasury Refactor) Companion for #7536 (Pallet Treasury Refactor) Nov 29, 2020
@ghost
Copy link

ghost commented Dec 16, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Dec 16, 2020

Checks failed; merge aborted.

gui1117
gui1117 reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polkadot and kusama proxy filter needs to be updated with bounty and tips call

runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
runtime/polkadot/src/lib.rs Outdated Show resolved Hide resolved
@gui1117 gui1117 added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Dec 16, 2020
@gui1117
Copy link
Contributor

gui1117 commented Dec 16, 2020

bot merge

@ghost
Copy link

ghost commented Dec 16, 2020

Trying merge.

@ghost ghost merged commit 465e358 into paritytech:master Dec 16, 2020
@s3krit
Copy link
Contributor

s3krit commented Dec 16, 2020

Should we have bumped transaction_version in the relevant chains for this PR?

@shawntabrizi
Copy link
Member

Should we have bumped transaction_version in the relevant chains for this PR?

Yes we should, but probably as a part of the release checklist not right now?

@shawntabrizi shawntabrizi mentioned this pull request Dec 16, 2020
Merged
@s3krit s3krit mentioned this pull request Jan 26, 2021
Merged
@aurexav aurexav mentioned this pull request Aug 18, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shamb0 @gui1117 @s3krit @shawntabrizi @ordian @paritytech-ci