Ensure extrinsics in the XCM pallet check for a configurable origin

[KiChjang]

Code patterns like the following:

pub fn force_unsubscribe_version_notify(
	origin: OriginFor<T>,
	location: Box<VersionedMultiLocation>,
) -> DispatchResult {
	ensure_root(origin)?;
	// ...
}

are common in the XCM pallet. This is undesirable as only root can call these extrinsics. Instead, going forward, what we should do is create a new config item called AdminOrigin, and check for that. This will allow the origin to have its own curve in Gov2.

[serkul]

Hi @KiChjang, can you take a look at the PR which I made for this issue?
I see that CI fails in cumulus, because AdminOrigin is missing there in impl pallet_xcm.... I don't know how to address this correctly since it's a separate repo. Maybe I misunderstood the task, but, how I see it, adding a new item in a pallet's config will require changes in all places where the pallet's config is implemented.

[KiChjang]

This is not meant to be worked on just yet; it's an issued filed specifically for XCM v3.

[serkul]

Ok, it wasn't obvious for me. I just saw an "easy" tag and thought it was a good issue to start with :) I'll close the PR then.

[KiChjang]

Since XCM v3 has just merged, this is free to be worked upon again.

[serkul]

@KiChjang, I see this issue stopped being "easy". Can I continue to work on it or should I leave it alone?

[KiChjang]

It's simply because we've removed that label, so I can't apply it on this issue. You are welcome to work on it.

[serkul]

after rebasing, there are Currency, CurrencyMatcher, TrustedLockers, SovereignAccountOf, MaxLockers, WeightInfo types that are missing in pallet_xcm::Config in runtime/rococo. Does it need to be fixed or I just reopen PR with some tests failing?

[KiChjang]

I unfortunately do not have the context of what you're talking about. It is likely to be a rebasing issue.

[serkul]

You are right, Keith , it was a rebasing issue. I opened a new [PR] (#6632). There are two label checks which fail, I guess, I cannot fix them myself.
Another failing check, as before XCM v3 merge ", is continuous-integration/gitlab-check-dependent-cumulus", because of the new config item.

[KiChjang]

Fixed in #6928.