Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Do not require to hash validation code prior to collation #4524

Closed
pepyakin opened this issue Dec 14, 2021 · 0 comments · Fixed by #4628
Closed

Do not require to hash validation code prior to collation #4524

pepyakin opened this issue Dec 14, 2021 · 0 comments · Fixed by #4628
Labels
I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@pepyakin
Copy link
Contributor

When creating a new collation, the collator has to provide the validation_code_hash via the candidate descriptor. Currently, for that the collation-generation subsystem would query validation_code via Runtime API and then hash it.

Instead, we could add a new runtime API in ParachainHost which would just return the current hash for the given para id. To be future proof, it should also take the assumption parameter (see for example validation_code).

Prior effort: #2907
@pepyakin pepyakin added the I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Dec 14, 2021
@pepyakin pepyakin mentioned this issue Dec 14, 2021
Closed
pepyakin added a commit that referenced this issue Dec 28, 2021
@pepyakin
runtime-api: add validation_code_hash API
e0b7f92 
This is the first step to close
#4524
pepyakin added a commit that referenced this issue Dec 28, 2021
@pepyakin
collation-gen: don't hash validation code
afcc16d 
Closes #4524
This was referenced Dec 28, 2021
Merged
Merged
@pepyakin pepyakin linked a pull request Dec 28, 2021 that will close this issue
collation-gen: don't hash validation code #4628
Merged
paritytech-processbot bot pushed a commit that referenced this issue Dec 28, 2021
@pepyakin
collation-gen: don't hash validation code (#4628)
d214150 
* runtime-api: add validation_code_hash API

This is the first step to close
#4524

* collation-gen: don't hash validation code

Closes #4524
drahnr pushed a commit that referenced this issue Jan 4, 2022
@pepyakin @drahnr
runtime-api: add validation_code_hash API (#4629)
28d1fef 
This is the first step to close
#4524
drahnr pushed a commit that referenced this issue Jan 4, 2022
@pepyakin @drahnr
collation-gen: don't hash validation code (#4628)
aab7694 
* runtime-api: add validation_code_hash API

This is the first step to close
#4524

* collation-gen: don't hash validation code

Closes #4524
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this issue Feb 3, 2022
@pepyakin @Wizdave97
runtime-api: add validation_code_hash API (paritytech#4629)
fa37372 
This is the first step to close
paritytech#4524
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this issue Feb 3, 2022
@pepyakin @Wizdave97
collation-gen: don't hash validation code (paritytech#4628)
a4a9333 
* runtime-api: add validation_code_hash API

This is the first step to close
paritytech#4524

* collation-gen: don't hash validation code

Closes paritytech#4524
ggwpez pushed a commit to ggwpez/runtimes that referenced this issue Mar 10, 2023
@pepyakin
runtime-api: add validation_code_hash API (#4629)
d8ce012 
This is the first step to close
paritytech/polkadot#4524
ggwpez pushed a commit to ggwpez/runtimes that referenced this issue Jul 13, 2023
@pepyakin
runtime-api: add validation_code_hash API (#4629)
623fbbe 
This is the first step to close
paritytech/polkadot#4524
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

collation-gen: don't hash validation code paritytech/polkadot
1 participant
@pepyakin