You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
we may want to allow assets below ExistentialDeposit directly into treasury account in the DropAssets case instead of go to AssetsTrap storage. As there're already an TakeRevenue trait in xcm-builder, we could just use this trait to do our deposit logic. another problem to be consideration is how to get ExistentialDeposit for different asset, the simple solution is just passing constant map.
By default in the relaychain side, the configuration could be (). in the parachain side, parachain can set different ExistentialDeposit value for different asset just like what we did in acala, and we can deposit those asset into treasury account too.
there're some rude code in this quick implementation needs to more discuss:
should we move TakeRevenue to xcm-executor/traits?
the get_by_key may be replaced if there're some existing utility method.
The text was updated successfully, but these errors were encountered:
zqhxuyuan
changed the title
DropAssets support assets below ExistentialDeposit deposit directly into treasury
Improve DropAssets to support assets below ExistentialDeposit into treasury
Nov 29, 2021
we may want to allow assets below
ExistentialDeposit
directly into treasury account in theDropAssets
case instead of go toAssetsTrap
storage. As there're already anTakeRevenue
trait inxcm-builder
, we could just use this trait to do our deposit logic. another problem to be consideration is how to getExistentialDeposit
for different asset, the simple solution is just passing constant map.By default in the relaychain side, the configuration could be
()
. in the parachain side, parachain can set differentExistentialDeposit
value for different asset just like what we did in acala, and we can deposit those asset into treasury account too.here is a quick prototype implementation. if it's reasonable, I can create an PR on polkadot codebase. @xlc @KiChjang
there're some rude code in this quick implementation needs to more discuss:
TakeRevenue
toxcm-executor/traits
?get_by_key
may be replaced if there're some existing utility method.The text was updated successfully, but these errors were encountered: