This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow retrying for rejected PVFs #4288
Assignees
Comments
mrcnski
added a commit
that referenced
this issue
Oct 30, 2022
- Keep track of the time of failure and the number of failures. - If we get a request to prepare a PVF, retry if: - Enough time has elapsed since a failure, and - The number of failures is not greater than `NUM_PREPARE_RETRIES` Closes #4288
mrcnski
added a commit
that referenced
this issue
Oct 30, 2022
- Keep track of the time of failure and the number of failures. - If we get a request to prepare a PVF, retry if: - Enough time has elapsed since a failure, and - The number of failures is not greater than `NUM_PREPARE_RETRIES` Closes #4288
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In case the PVF validation host gets a precheck_pvf/execute_pvf request and it knows that preparation for that PVF is already failed, and a certain amount of time has passed since that attempt, the validation host should give that PVF another shot.
Naively, validation host should probably remember at which time it compiled the artifact in question. During the preparation request we won't bail unconditionally if the artifact is already in memory, but check if the cooldown period has passed and if so we try again.
The text was updated successfully, but these errors were encountered: