This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Co reducing fast-unstake bench time and more (#6552)
* update stuff
* remove
* update
* update
* update weights
* fix tests
* update weights
* fix a few small things
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* ".git/.scripts/commands/bench/bench.sh" runtime kusama-dev pallet-fast-unstake
* reduce batch size
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* update
* fix
* fix
* ".git/.scripts/commands/bench/bench.sh" runtime polkadot-dev pallet-fast-unstake
* update lockfile for {"substrate"}
* fmt
* Env gate migration try_fast_unstake_all
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
---------
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>- Loading branch information
1 parent
45f4155
commit 9433dc6
Showing
10 changed files
with
577 additions
and
304 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| // Copyright 2023 Parity Technologies (UK) Ltd. | ||
| // This file is part of Polkadot. | ||
|
|
||
| // Polkadot is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
|
|
||
| // Polkadot is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
|
|
||
| // You should have received a copy of the GNU General Public License | ||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Common try-runtime only tests for runtimes. | ||
|
|
||
| use frame_support::{ | ||
| dispatch::RawOrigin, | ||
| traits::{Get, Hooks}, | ||
| }; | ||
| use pallet_fast_unstake::{Pallet as FastUnstake, *}; | ||
| use pallet_staking::*; | ||
| use sp_std::{collections::btree_set::BTreeSet, prelude::*}; | ||
|
|
||
| /// register all inactive nominators for fast-unstake, and progress until they have all been | ||
| /// processed. | ||
| pub fn migrate_all_inactive_nominators<T: pallet_fast_unstake::Config + pallet_staking::Config>() | ||
| where | ||
| <T as frame_system::Config>::RuntimeEvent: TryInto<pallet_fast_unstake::Event<T>>, | ||
| { | ||
| let mut unstaked_ok = 0; | ||
| let mut unstaked_err = 0; | ||
| let mut unstaked_slashed = 0; | ||
|
|
||
| let all_stakers = Ledger::<T>::iter().map(|(ctrl, l)| (ctrl, l.stash)).collect::<BTreeSet<_>>(); | ||
| let mut all_exposed = BTreeSet::new(); | ||
| ErasStakers::<T>::iter().for_each(|(_, val, expo)| { | ||
| all_exposed.insert(val); | ||
| all_exposed.extend(expo.others.iter().map(|ie| ie.who.clone())) | ||
| }); | ||
|
|
||
| let eligible = all_stakers | ||
| .iter() | ||
| .filter_map(|(ctrl, stash)| all_exposed.contains(stash).then_some(ctrl)) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| log::info!( | ||
| target: "runtime::test", | ||
| "registering {} out of {} stakers for fast-unstake", | ||
| eligible.len(), | ||
| all_stakers.len() | ||
| ); | ||
| for ctrl in eligible { | ||
| if let Err(why) = | ||
| FastUnstake::<T>::register_fast_unstake(RawOrigin::Signed(ctrl.clone()).into()) | ||
| { | ||
| log::warn!(target: "runtime::test", "failed to register {:?} due to {:?}", ctrl, why); | ||
| } | ||
| } | ||
|
|
||
| log::info!( | ||
| target: "runtime::test", | ||
| "registered {} successfully, starting at {:?}.", | ||
| Queue::<T>::count(), | ||
| frame_system::Pallet::<T>::block_number(), | ||
| ); | ||
| while Queue::<T>::count() != 0 || Head::<T>::get().is_some() { | ||
| let now = frame_system::Pallet::<T>::block_number(); | ||
| let weight = <T as frame_system::Config>::BlockWeights::get().max_block; | ||
| let consumed = FastUnstake::<T>::on_idle(now, weight); | ||
| log::debug!(target: "runtime::test", "consumed {:?} ({})", consumed, consumed.ref_time() as f32 / weight.ref_time() as f32); | ||
|
|
||
| frame_system::Pallet::<T>::read_events_no_consensus() | ||
| .into_iter() | ||
| .map(|r| r.event) | ||
| .filter_map(|e| { | ||
| let maybe_fast_unstake_event: Option<pallet_fast_unstake::Event<T>> = | ||
| e.try_into().ok(); | ||
| maybe_fast_unstake_event | ||
| }) | ||
| .for_each(|e: pallet_fast_unstake::Event<T>| match e { | ||
| pallet_fast_unstake::Event::<T>::Unstaked { result, .. } => | ||
| if result.is_ok() { | ||
| unstaked_ok += 1; | ||
| } else { | ||
| unstaked_err += 1 | ||
| }, | ||
| pallet_fast_unstake::Event::<T>::Slashed { .. } => unstaked_slashed += 1, | ||
| pallet_fast_unstake::Event::<T>::InternalError => unreachable!(), | ||
| _ => {}, | ||
| }); | ||
|
|
||
| if now % 100u32.into() == sp_runtime::traits::Zero::zero() { | ||
| log::info!( | ||
| target: "runtime::test", | ||
| "status: ok {}, err {}, slash {}", | ||
| unstaked_ok, | ||
| unstaked_err, | ||
| unstaked_slashed, | ||
| ); | ||
| } | ||
|
|
||
| frame_system::Pallet::<T>::reset_events(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.