av-store: Move prune on a separte thread

There are situations where pruning of the data could take more than a few
seconds and that might make the whole subsystem unreponsive. To avoid this just
move the prune process on a separate thread.

See: #7237, for more details.

Signed-off-by: Alexandru Gheorghe <[email protected]>

node/core/av-store/src/lib.rs

@@ -614,7 +614,17 @@ async fn run_iteration<Context>(
 			*next_pruning = Delay::new(subsystem.pruning_config.pruning_interval).fuse();
 
 			let _timer = subsystem.metrics.time_pruning();
-			prune_all(&subsystem.db, &subsystem.config, &*subsystem.clock)?;
+
+			let db = subsystem.db.clone();
+			let config = subsystem.config.clone();
+			let time_now = subsystem.clock.now()?;
+			ctx.spawn_blocking("av-store-prunning", Box::pin(async move {
+				// TODO: The loop was existing on fatal errors from prune_all.
+				// probably we should achieve the same here.
+				if let Err(err) = prune_all(&db, &config, time_now) {
+					err.trace();
+				}
+			}))?;
 		}
 	}
 
@@ -1250,8 +1260,7 @@ fn store_available_data(
 	Ok(())
 }
 
-fn prune_all(db: &Arc<dyn Database>, config: &Config, clock: &dyn Clock) -> Result<(), Error> {
-	let now = clock.now()?;
+fn prune_all(db: &Arc<dyn Database>, config: &Config, now: Duration) -> Result<(), Error> {
 	let (range_start, range_end) = pruning_range(now);
 
 	let mut tx = DBTransaction::new();