feat: add feasibility_check on mined solution
#483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
feasibility_check on mined solutionfeasibility_check on mined solution
niklasad1
commented
Mar 28, 2023
niklasad1
commented
Mar 28, 2023
| pub fn mock_votes(voters: u32, desired_targets: u16) -> Vec<(u32, u16)> { | ||
| assert!(voters >= desired_targets as u32); | ||
| (0..voters).zip((0..desired_targets).cycle()).collect() | ||
| pub fn mock_votes(voters: u32, desired_targets: u16) -> Option<Vec<(u32, u16)>> { |
There was a problem hiding this comment.
refactored to not panic with weird input here
niklasad1
commented
Mar 28, 2023
| active_voters, | ||
| desired_targets.try_into().expect("Desired targets < u16::MAX"), | ||
| ) else { | ||
| return Weight::MAX; |
There was a problem hiding this comment.
refactored not to panic on weird input, Weight::MAX was the best I could come with i.e, just throw away the result
gpestana
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #480 #498
You don't have to review the
staking-miner-playgroundcarefully it simply updates substrate to get the latest EPM changes in the metadata.