Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: Send already connected peers to new subscribers #7011

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

dmitry-markin
Copy link
Contributor

Introduce SyncEvent::InitialPeers message sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in #6573 (comment).

Fixes #6573.

@dmitry-markin dmitry-markin added the T0-node This PR/Issue is related to the topic “node”. label Dec 27, 2024
@dmitry-markin dmitry-markin requested a review from bkchr December 27, 2024 16:54
@dmitry-markin
Copy link
Contributor Author

/cmd prdoc --audience node_dev --bump major

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

prdoc/pr_7011.prdoc Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from a team December 28, 2024 19:57
Co-authored-by: Bastian Köcher <[email protected]>
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12536695325
Failed job name: test-linux-stable-no-try-runtime

@bkchr bkchr requested a review from skunert December 29, 2024 22:06
@dmitry-markin dmitry-markin added this pull request to the merge queue Dec 30, 2024
Merged via the queue into master with commit b4177a9 Dec 30, 2024
195 of 201 checks passed
@dmitry-markin dmitry-markin deleted the dm-sync-peers-state-event branch December 30, 2024 15:02
Copy link
Contributor

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @dmitry-markin 🙌

dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to
allow them correctly tracking sync peers. This resolves a race condition
described in
paritytech#6573 (comment).

Fixes paritytech#6573.

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
@dmitry-markin dmitry-markin added the A4-needs-backport Pull request must be backported to all maintained releases. label Jan 6, 2025
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to
allow them correctly tracking sync peers. This resolves a race condition
described in
#6573 (comment).

Fixes #6573.

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit b4177a9)
@paritytech-cmd-bot-polkadot-sdk

Successfully created backport PR for stable2407:

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to
allow them correctly tracking sync peers. This resolves a race condition
described in
#6573 (comment).

Fixes #6573.

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit b4177a9)
@paritytech-cmd-bot-polkadot-sdk

Successfully created backport PR for stable2409:

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to
allow them correctly tracking sync peers. This resolves a race condition
described in
#6573 (comment).

Fixes #6573.

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit b4177a9)
@paritytech-cmd-bot-polkadot-sdk

Successfully created backport PR for stable2412:

ordian added a commit that referenced this pull request Jan 7, 2025
* master: (256 commits)
  fix chunk fetching network compatibility zombienet test (#6988)
  chore: delete repeat words (#7034)
  Print taplo version in CI (#7041)
  Implement cumulus StorageWeightReclaim as wrapping transaction extension + frame system ReclaimWeight (#6140)
  Make `TransactionExtension` tuple of tuple transparent for implication (#7028)
  Replace duplicated whitelist with whitelisted_storage_keys (#7024)
  [WIP] Fix networking-benchmarks (#7036)
  [docs] Fix release naming (#7032)
  migrate pallet-mixnet to umbrella crate (#6986)
  Improve remote externalities logging (#7021)
  Fix polkadot sdk doc. (#7022)
  Remove warning log from frame-omni-bencher CLI (#7020)
  [pallet-revive] fix file case (#6981)
  Add workflow for networking benchmarks (#7029)
  [CI] Skip SemVer on R0-silent and update docs (#6285)
  correct path in cumulus README (#7001)
  sync: Send already connected peers to new subscribers (#7011)
  Excluding chainlink domain for link checker CI (#6524)
  pallet-bounties: Fix benchmarks for 0 ED (#7013)
  Log peerset set ID -> protocol name mapping (#7005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

Fix flaky zombienet test zombienet-cumulus-0002-pov_recovery
4 participants