Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cumulus: bump PARENT_SEARCH_DEPTH and add test for 12-core elastic scaling #6983

Open
wants to merge 6 commits into
base: alindima/zombienet-sdk-rewrite
Choose a base branch
from

Conversation

alindima
Copy link
Contributor

On top of #6757

Fixes #6858 by bumping the PARENT_SEARCH_DEPTH constant to a larger value (30) and adds a zombienet-sdk test that exercises the 12-core scenario.

This is a node-side limit that restricts the number of allowed pending availability candidates when choosing the parent parablock during authoring.
This limit is rather redundant, as the parachain runtime already restricts the unincluded segment length to the configured value in the FixedVelocityConsensusHook (which ideally should be equal to this PARENT_SEARCH_DEPTH).

For 12 cores, a value of 24 should be enough, but I bumped it to 30 to have some extra buffer.

There are two other potential ways of fixing this:

  • remove this constant altogether, as the parachain runtime already makes those guarantees. Chose not to do this, as it can't hurt to have an extra safeguard
  • set this value to be equal to the uninlcuded segment size. This value however is not exposed to the node-side and would require a new runtime API, which seems overkill for a redundant check.

@alindima alindima added the T9-cumulus This PR/Issue is related to cumulus. label Dec 23, 2024
@alindima alindima requested a review from a team as a code owner December 23, 2024 09:49
@alindima alindima requested a review from skunert December 23, 2024 09:49
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12464793256
Failed job name: build-rustdoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant