-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastic scaling: rework core selector handling #6939
Open
alindima
wants to merge
42
commits into
master
Choose a base branch
from
alindima/remove-experimental-ump-signals-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
elastic scaling: rework core selector handling #6939
alindima
wants to merge
42
commits into
master
from
alindima/remove-experimental-ump-signals-feature
+293
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dima/remove-experimental-ump-signals-feature
…erimental-ump-signals-feature
alindima
added
T8-polkadot
This PR/Issue is related to/affects the Polkadot network.
T9-cumulus
This PR/Issue is related to cumulus.
labels
Dec 18, 2024
4 tasks
All GitHub workflows were cancelled due to failure one of the required jobs. |
skunert
reviewed
Dec 19, 2024
…erimental-ump-signals-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T8-polkadot
This PR/Issue is related to/affects the Polkadot network.
T9-cumulus
This PR/Issue is related to cumulus.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the PR, the parachain runtimes were prevented from sending the core selector ump signal by the
experimental-ump-signals
compile-time feature. This was needed because the validators were not yet upgraded to be able to decode the new signals.This PR removes the
experimental-ump-signals
feature and makes the runtime send the UMP signal if theSelectCore
impl (part of the runtime config trait) returnsSome(...)
. This is a breaking change on the SelectCore trait so cannot be backported.It also adds an impl for
()
, which returnsNone
.Instructions on how to configure the parachain runtime for elastic scaling will be included in #6739