Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omni-node: Tolerate failing metadata check #6923

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Dec 17, 2024

#6450 introduced metadata checks. Supported are metadata v14 and higher.

However, of course old chain-specs have a genesis code blob that might be on older version. This needs to be tolerated. We should just skip the checks in that case.

Fixes #6921

@skunert skunert added T9-cumulus This PR/Issue is related to cumulus. A4-needs-backport Pull request must be backported to all maintained releases. labels Dec 17, 2024
@skunert
Copy link
Contributor Author

skunert commented Dec 17, 2024

/cmd prdoc --bump patch --audience node_operator

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just activate the legacy feature of frame-metadata to have decoding work for all metadata's?

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in DM, let's merge this and see if we can prevent this from happening in the future.

@bkchr bkchr added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit e6ddd39 Dec 17, 2024
196 of 200 checks passed
@bkchr bkchr deleted the skunert/omni-node-metadata branch December 17, 2024 21:17
@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6923-to-stable2407
git worktree add --checkout .worktree/backport-6923-to-stable2407 backport-6923-to-stable2407
cd .worktree/backport-6923-to-stable2407
git reset --hard HEAD^
git cherry-pick -x e6ddd3925693adbf538a438c94dc66e66eba9bed
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6923-to-stable2409
git worktree add --checkout .worktree/backport-6923-to-stable2409 backport-6923-to-stable2409
cd .worktree/backport-6923-to-stable2409
git reset --hard HEAD^
git cherry-pick -x e6ddd3925693adbf538a438c94dc66e66eba9bed
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2412:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6923-to-stable2412
git worktree add --checkout .worktree/backport-6923-to-stable2412 backport-6923-to-stable2412
cd .worktree/backport-6923-to-stable2412
git reset --hard HEAD^
git cherry-pick -x e6ddd3925693adbf538a438c94dc66e66eba9bed
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T9-cumulus This PR/Issue is related to cumulus.
Projects
Status: No status
Status: done
Development

Successfully merging this pull request may close these issues.

omni-node: Cannot try_into() to Metadata: unsupported metadata version
3 participants