[pallet-revive] implement the ref_time_left API #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xermicus <[email protected]>
xermicus
added
R0-silent
|
bot fmt |
|
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7923861 was started for your command Comment |
|
@xermicus Command |
|
/cmd prdoc --audience runtime_dev --bump minor |
|
/cmd bench --runtime dev --pallet pallet_revive |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
athei
reviewed
Dec 16, 2024
Signed-off-by: Cyrill Leutwiler <[email protected]>
athei
approved these changes
Dec 16, 2024
pgherveou
approved these changes
Dec 17, 2024
| @@ -388,6 +388,9 @@ pub trait HostFn: private::Sealed { | |||
| /// - `offset`: Byte offset into the returned data | |||
| fn return_data_copy(output: &mut &mut [u8], offset: u32); | |||
|
|
|||
| /// Returns the amount of ref_time left. | |||
| fn ref_time_left() -> u64; | |||
There was a problem hiding this comment.
I am thinking, it would be nice to get links to https://www.evm.codes/?fork=cancun#37gas for all these evm apis
There was a problem hiding this comment.
Yeah why not, I will make a followup up for it :)
|
/cmd bench --runtime dev --pallet pallet_revive |
|
/cmd bench --runtime dev --pallet pallet_revive |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
Command "bench --runtime dev --pallet pallet_revive" has failed ❌! See logs here Command output:✅ Successful benchmarks of runtimes/pallets: |
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ref_time_left API method. Solidity knows only a single "gas" dimension; Solidity contracts will use this to query the gas left.