-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pallet-revive: Fix docs.rs #6896
Conversation
All GitHub workflows were cancelled due to failure one of the required jobs. |
bot fmt |
@athei https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7924317 was started for your command Comment |
@athei Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see prdoc entry, should this have one? Description could explain migration to unstable_hostfn, which would then also help to review the PR overall.
I mean structure of this is like:
- There's actually only one quite scoped change.
- Rest "ripples" from that.
So explaining 1 would help others to understand this.
/cmd prdoc --audience runtime_dev |
Ooops. Yeah we need a prdoc in order to bump the pallets on release. Generated from PR description. |
Hmm... there's a way to generate it? :-) I've created the file manually. |
prdoc/pr_6896.prdoc
Outdated
doc: | ||
- audience: Runtime Dev | ||
description: |- | ||
- Fixed failing docs.rs build for `pallet-revive-uapi` by fixing a wring attribute in the manifest (we were using `default-target` instead of `targets`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wring i.e. wiring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is my only complaint, otherwise makes sense
pallet-revive-uapi
by fixing a wring attribute in the manifest (we were usingdefault-target
instead oftargets
)unstable-api
feature flag topallet-revive
#6866 won't work on themunstable-hostfn
feature tag will show up on the functions that are guarded behind it.