Omni-node: Detect pending code in storage and send go ahead signal in dev-mode. #6885
Conversation
|
/cmd prdoc --bump patch --audience runtime_dev |
| let should_send_go_ahead = client_for_cidp | ||
| .storage(block, &StorageKey(PENDING_VALIDATION_CODE_KEY.to_vec())) | ||
| .ok() |
There was a problem hiding this comment.
If someone names ParachainSystem differently in construct_runtime!, this will fail.
IMO it is better to call collect_collation_info at block and check if new_validation_code is Some(_).
There was a problem hiding this comment.
I was totally willing to take that risk :D. But yeah your idea is better. Not checking the runtime api version though, 3 year old runtimes with the manual seal of omni node seems exotic.
skunert
added
the
A4-needs-backport
There was a problem hiding this comment.
Thank you very much!
Would be great to backport this into the next patch of 202412 so it can be used in documentation
update: bot should open the PR automatically: https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6885-to-stable2407
git worktree add --checkout .worktree/backport-6885-to-stable2407 backport-6885-to-stable2407
cd .worktree/backport-6885-to-stable2407
git reset --hard HEAD^
git cherry-pick -x cee63ac0a34f356c66f1305073fa3d1210550a0c
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6885-to-stable2409
git worktree add --checkout .worktree/backport-6885-to-stable2409 backport-6885-to-stable2409
cd .worktree/backport-6885-to-stable2409
git reset --hard HEAD^
git cherry-pick -x cee63ac0a34f356c66f1305073fa3d1210550a0c
git push --force-with-lease |
|
Successfully created backport PR for |
Backport #6885 into `stable2412` from skunert. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Sebastian Kunert <[email protected]>
We check if there is a pending validation code in storage. If there is, add the go-ahead signal in the relay chain storage proof.
Not super elegant, but should get the job done for development.