Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport aliasers to westend to stable2412 #6849

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

franciscoaguirre
Copy link
Contributor

Backporting #6814 to stable2412 so we can test the new XCM scenario of doing a cross-chain transfer and a transact on the same step.

`InitiateTransfer`, the new instruction introduced in XCMv5, allows
preserving the origin after a cross-chain transfer via the usage of the
`AliasOrigin` instruction. The receiving chain needs to be configured to
allow such this instruction to have its intended effect and not just
throw an error.

In this PR, I add the alias rules specified in the [RFC for origin
preservation](https://github.com/polkadot-fellows/RFCs/blob/main/text/0122-alias-origin-on-asset-transfers.md)
to westend chains so we can test these scenarios in the testnet.

The new scenarios include:
- Sending a cross-chain transfer from one system chain to another and
doing a Transact on the same message (1 hop)
- Sending a reserve asset transfer from one chain to another going
through asset hub and doing Transact on the same message (2 hops)

The updated chains are:
- Relay: added `AliasChildLocation`
- Collectives: added `AliasChildLocation` and
`AliasOriginRootUsingFilter<AssetHubLocation, Everything>`
- People: added `AliasChildLocation` and
`AliasOriginRootUsingFilter<AssetHubLocation, Everything>`
- Coretime: added `AliasChildLocation` and
`AliasOriginRootUsingFilter<AssetHubLocation, Everything>`

AssetHub already has `AliasChildLocation` and doesn't need the other
config item.
BridgeHub is not intended to be used by end users so I didn't add any
config item.
Only added `AliasChildOrigin` to the relay since we intend for it to be
used less.

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: command-bot <>
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner December 11, 2024 15:38
@franciscoaguirre franciscoaguirre self-assigned this Dec 11, 2024
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Dec 11, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

acatangiu
acatangiu previously approved these changes Dec 11, 2024
x3c41a
x3c41a previously approved these changes Dec 11, 2024
@bkontur bkontur enabled auto-merge (squash) December 11, 2024 20:21
@EgorPopelyaev EgorPopelyaev merged commit 2bf2fd0 into stable2412 Dec 12, 2024
196 of 199 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-aliasers-to-westend branch December 12, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants