Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCM V5 - Backport SetHints instruction (#6566) #6809

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

franciscoaguirre
Copy link
Contributor

Backporting #6566 to stable2412

Last feature we wanted for V5, changing SetAssetClaimer to be just one of many possible "hints" that you can specify at the beginning of your program to change its behaviour.

This makes it easier to add new hints in the future and have barriers accept them.

Last feature we wanted for V5, changing `SetAssetClaimer` to be just one
of many possible "hints" that you can specify at the beginning of your
program to change its behaviour.

This makes it easier to add new hints in the future and have barriers
accept them.

---------

Co-authored-by: GitHub Action <[email protected]>
@franciscoaguirre franciscoaguirre added T6-XCM This PR/Issue is related to XCM. A3-backport Pull request is already reviewed well in another branch. labels Dec 9, 2024
@franciscoaguirre franciscoaguirre self-assigned this Dec 9, 2024
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner December 9, 2024 18:31
Copy link
Contributor

github-actions bot commented Dec 9, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

bkontur
bkontur previously approved these changes Dec 9, 2024
@bkontur
Copy link
Contributor

bkontur commented Dec 9, 2024

/cmd fmt

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Command "fmt" has started 🚀 See logs here

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Command "fmt" has finished ✅ See logs here

@EgorPopelyaev EgorPopelyaev merged commit 3ba7dbf into stable2412 Dec 11, 2024
4 checks passed
@EgorPopelyaev EgorPopelyaev deleted the set-hints-backport branch December 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants