Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one ParaId variable in the Parachain Template #6744

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

shawntabrizi
Copy link
Member

Many problems can occur when building and testing a Parachain caused by misconfiguring the paraid.

This can happen when there are 3 different places you need to update!

This PR makes it so a SINGLE location is the source of truth for the ParaId.

@shawntabrizi
Copy link
Member Author

/command prdoc --audience=runtime dev --bump=minor

@shawntabrizi
Copy link
Member Author

/cmd --audience runtime_dev --bump minor

Copy link

github-actions bot commented Dec 3, 2024

Command "--audience runtime_dev --bump minor" has started 🚀 See logs here

Copy link

github-actions bot commented Dec 3, 2024

Command "--audience runtime_dev --bump minor" has failed ❌! See logs here

@shawntabrizi
Copy link
Member Author

/cmd --audience runtime_dev --bump minor

Copy link

github-actions bot commented Dec 3, 2024

Command "--audience runtime_dev --bump minor" has started 🚀 See logs here

Copy link

github-actions bot commented Dec 3, 2024

Command "--audience runtime_dev --bump minor" has failed ❌! See logs here

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

templates/parachain/node/src/chain_spec.rs Outdated Show resolved Hide resolved
@iulianbarbu iulianbarbu added the R0-silent Changes should not be mentioned in any release notes label Dec 4, 2024
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12163188464
Failed job name: cargo-clippy

@shawntabrizi shawntabrizi added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@shawntabrizi shawntabrizi added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@bkchr bkchr added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 482bf08 Dec 13, 2024
199 of 200 checks passed
@bkchr bkchr deleted the shawntabrizi-one-paraid-template branch December 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants