Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DHT content providers API from sc-network #6711

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

dmitry-markin
Copy link
Contributor

Expose the Kademlia content providers API for the use by sc-network client code:

  1. Extend the NetworkDHTProvider trait with functions to start/stop providing content and query the DHT for the list of content providers for a given key.
  2. Extend the DhtEvent enum with events reporting the found providers or query failures.
  3. Implement the above for libp2p & litep2p network backends.

@dmitry-markin dmitry-markin added the T0-node This PR/Issue is related to the topic “node”. label Nov 29, 2024
@dmitry-markin dmitry-markin self-assigned this Nov 29, 2024
@dmitry-markin
Copy link
Contributor Author

/cmd prdoc --audience node_dev

@dmitry-markin
Copy link
Contributor Author

It looks like the CI always gets stuck after a /cmd prdoc command. Another PR where I had to manually kick the CI after /cmd prdoc is #6703.

CC @alvicsam

Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitry-markin dmitry-markin added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 4b054c6 Dec 13, 2024
195 of 199 checks passed
@dmitry-markin dmitry-markin deleted the dm-expose-providers-api branch December 13, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

4 participants