Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport/rpc-v2: Implement archive_unstable_storageDiff (stable2412) #6709

Merged
merged 1 commit into from
Dec 3, 2024
Merged

backport/rpc-v2: Implement archive_unstable_storageDiff (stable2412) #6709

merged 1 commit into from
Dec 3, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Nov 29, 2024 •
edited
Loading

Backport for: #5997

cc @paritytech/subxt-team

@lexnv @jsdw
rpc-v2: Implement archive_unstable_storageDiff (#5997)
4d350e5 
This PR implements the `archive_unstable_storageDiff`.

The implementation follows the rpc-v2 spec from:
-  paritytech/json-rpc-interface-spec#159.
- builds on top of
paritytech/json-rpc-interface-spec#161

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: James Wilson <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv added the A3-backport Pull request is already reviewed well in another branch. label Nov 29, 2024
@lexnv lexnv self-assigned this Nov 29, 2024
@lexnv lexnv mentioned this pull request Nov 29, 2024
Merged
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@lexnv lexnv requested a review from EgorPopelyaev November 29, 2024 17:42
@EgorPopelyaev EgorPopelyaev merged commit 919663c into stable2412 Dec 3, 2024
197 of 206 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport/archive-methods branch December 3, 2024 11:05
EgorPopelyaev pushed a commit that referenced this pull request Dec 4, 2024
@lexnv @jsdw
backport/rpc-v2: Refactor archive_storage method into subscription (#…
8ac3ba8 
…6483) (#6710)

Backports: #6483

Builds on top of the backport:
#6709

cc @paritytech/subxt-team

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: James Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

Assignees

@lexnv lexnv

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lexnv @EgorPopelyaev @niklasad1